From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29078 invoked by alias); 22 Oct 2013 18:26:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29046 invoked by uid 89); 22 Oct 2013 18:25:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2013 18:25:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9MIPr3U028878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Oct 2013 14:25:54 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9MIPqMF023057 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 22 Oct 2013 14:25:53 -0400 Message-ID: <5266C330.1090101@redhat.com> Date: Tue, 22 Oct 2013 18:26:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller CC: "'gdb-patches'" Subject: Re: [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts. References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <003b01cebaf3$a2d79620$e886c260$@muller@ics-cnrs.unistra.fr> <524A2329.3030706@redhat.com> <000901cebeab$a83936d0$f8aba470$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000901cebeab$a83936d0$f8aba470$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00702.txt.bz2 On 10/01/2013 06:39 AM, Pierre Muller wrote: > (gdb) PASS: gdb.base/printcmds.exp: set print elements 0 > p teststring > $554 = <__cygwin_cxx_malloc+128> "teststring contents" [snip] Ah, that's good enough evidence for me. >>> The last errors were generated by the use of Ctrl-V >>> to avoid problems with possible association of @ to kill command. >>> mingw GDB doesn't handle this Ctrl-V, so I conditionally removed it > for >>> *-*-mingw* hosts. >> >> This isn't so much a question for you specifically, but I thought I'd >> throw this out to the greater wisdom of the list. >> >> I searched around the test suite and found a bunch of places where this >> character is used without the ^V hack. Is it (still) necessary at all? >> Perhaps we can just get rid of it entirely? > > I have no idea... > I just played it save by disabling only for MinGW hosts... I say get rid of it. This is the only place where this is done, and if this is really necessary, there are several other places where it should have been done. So I'm assuming it is no longer strictly necessary. >> Otherwise, given the harmless nature of the changes, I'd recommend that >> a maintainer approve this. With that, I think a maintainer should give this a final review and approval. Keith