From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26766 invoked by alias); 22 Oct 2013 18:25:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26756 invoked by uid 89); 22 Oct 2013 18:24:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2013 18:24:58 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9MIOrdT027165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Oct 2013 14:24:54 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9MIOrXf029995 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 22 Oct 2013 14:24:53 -0400 Message-ID: <5266C2F5.2090304@redhat.com> Date: Tue, 22 Oct 2013 18:25:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller CC: "'gdb-patches'" Subject: Re: [RFC 2/6] Avoid missing char before incomplete sequence in wchar_iterate. References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <002f01cebaf2$aac80410$00580c30$@muller@ics-cnrs.unistra.fr> <524A2316.8020607@redhat.com> <001201cebea4$700a4bc0$501ee340$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001201cebea4$700a4bc0$501ee340$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00700.txt.bz2 On 10/01/2013 05:47 AM, Pierre Muller wrote: > Here is a test, maybe this is overkill... There is no such thing as overkill in testing. :-) > On a linux machine with charset set to UTF-8, > I do get failures, but not all are related to the fix in the patch... > Some are due to the fact that Nevertheless, incomplete_LSE, incomplete_RSE and incomplete_SSE > do show one missing char. > > FAIL: gdb.base/printcmds.exp: print incomplete_LLE > FAIL: gdb.base/printcmds.exp: print incomplete_RLE > FAIL: gdb.base/printcmds.exp: print incomplete_SLE > FAIL: gdb.base/printcmds.exp: print incomplete_LRE > FAIL: gdb.base/printcmds.exp: print incomplete_RRE > FAIL: gdb.base/printcmds.exp: print incomplete_SRE > FAIL: gdb.base/printcmds.exp: print incomplete_LSE > FAIL: gdb.base/printcmds.exp: print incomplete_RSE > FAIL: gdb.base/printcmds.exp: print incomplete_SSE I'm not seeing these fail on my box, which defaults to UTF-8. But there are two minor problems. It looks like py-prettyprint.exp needs updating. That test prints a string with an invalid sequence much like what you're trying to fix: print estring2 $9 = "embedded x", (gdb) FAIL: gdb.python/py-prettyprint.exp: print estring2 In this case, the 'x' is "new" to the output. [It does this twice, in both tests named "print estring2". Ick. This file has duplicate test names.] > PS: One missing thing is the re-indentation of the exp > file for the additional foreach loop... > But using vim in visual mode and '>' command > added directly 8 spaces, instead of 4... > Doing all that by hand is really frustrating... > Should .exp files be treated differently from other tcl files? Not as far as I know... At least, I've never done anything special with indentation, but I use emacs, and that picks up gdb/.dir-locals.el, which specifies 4-space tabs for Tcl: (tcl-mode . ((tcl-indent-level . 4) (tcl-continued-indent-level . 4) (indent-tabs-mode . t))) Keith