From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15980 invoked by alias); 14 Oct 2013 08:19:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15967 invoked by uid 89); 14 Oct 2013 08:19:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2013 08:19:34 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VVdNB-0003OR-Iv from Yao_Qi@mentor.com ; Mon, 14 Oct 2013 01:19:29 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 14 Oct 2013 01:19:29 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 14 Oct 2013 01:19:29 -0700 Message-ID: <525BA8C0.9000101@codesourcery.com> Date: Mon, 14 Oct 2013 08:19:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH 4/7] Move struct varobj to varobj.h. References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-5-git-send-email-yao@codesourcery.com> <20131002094636.GC2971@adacore.com> <525103F5.90607@codesourcery.com> <20131008045620.GD3092@adacore.com> In-Reply-To: <20131008045620.GD3092@adacore.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00424.txt.bz2 On 10/08/2013 12:56 PM, Joel Brobecker wrote: > It does look a lot better to me, FWIW. The only possibly contentious > question left would be making struct varobj public, when I personally > tend to prefer opaque structures. But I'm fine with this step, as it > helps achieve the goal of moving the language-specific stuff out of > varobj.c. I think Doug also pretty much agreed to that change. I would > give the patch, say, until the end of the week, JIC others want to > comment in. > >> > #if HAVE_PYTHON >> > if (gdb_python_initialized) >> > { >> >- PyObject *value_formatter = var->pretty_printer; >> >+ PyObject *value_formatter= var->dynamic->pretty_printer; > You accidently removed a space before '='. > Oh, fixed. >> >+/* Every variable in the system has a structure of this type defined >> >+ for it. This structure holds all information necessary to manipulate >> >+ a particular object variable. Members which must be freed are noted. */ >> >+struct varobj >> >+{ > Not sure if there is a rule for it, or not. But I tend to prefer an > empty line between documentation and structure as well (same as with > subprograms). Add it if you agree, or else feel free to ignore. This > is just an arbitrary preference, AFAIK, and it really does not matter > much to me. I am fine to add a blank between doc and structure. Patch is committed. -- Yao (齐尧)