From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 879 invoked by alias); 10 Oct 2013 12:23:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 869 invoked by uid 89); 10 Oct 2013 12:23:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 12:23:14 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9ACNC2Q022750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Oct 2013 08:23:13 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9ACNAhD026643; Thu, 10 Oct 2013 08:23:11 -0400 Message-ID: <52569C2E.3020001@redhat.com> Date: Thu, 10 Oct 2013 12:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ondrej Oprala CC: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 02/18] poison "new" References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-3-git-send-email-ooprala@redhat.com> In-Reply-To: <1381339053-14519-3-git-send-email-ooprala@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00340.txt.bz2 Hello, On 10/09/2013 06:17 PM, Ondrej Oprala wrote: > * buildsym.c(new_ctx) : Likewise. Sorry, minor, boring, trivial detail. Space before '(' missing, and there should be no space before ':'. The '*' should be indented with a tab. Like: * buildsym.c (new_ctx): Likewise. (These little issues appear throughout the series.) -- Pedro Alves