Re: [PATCH 1/3] New make target 'check-perf' and new dir gdb.perf

Yao Qi
2013-10-10T00:29:19Z

On 10/09/2013 01:13 PM, Doug Evans wrote:
> I realize this is cut-n-paste-n-tweaking existing code,
> I'm just curious under what scenario the mkdir is needed (except for a
> broken build tree).
>

These dirs (testsuite/gdb.*) are there after configure and make.

>> >+ $(DO_RUNTEST) --directory=gdb.perf --outdir gdb.perf $(RUNTESTFLAGS) GDB_PERFORMANCE=yes
> I don't know if it'll ever be useful, but if GDB_PERFORMANCE=yes
> appears before RUNTESTFLAGS, then it can be overridden on the command
> line.
>

We should have the flexibility to set GDB_PERFORMANCE=yes|compile|run in
the command line.

>
> I was thinking there is one time when IWBN to run the tests in parallel:
> If I make a change to the test harness, I may want to run all the
> tests in some reduced-size mode to verify I haven't broken anything.
> I won't care what the perf results are - I'll just want to know that
> things still work.:-) This can be left for later though.

Or we can add some test cases to perf test harness, and they can be
started by 'make check' too.

--
Yao (é½å°§)