From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29141 invoked by alias); 10 Oct 2013 00:19:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29132 invoked by uid 89); 10 Oct 2013 00:19:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 00:19:04 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VU3xz-0007gi-Rx from Yao_Qi@mentor.com ; Wed, 09 Oct 2013 17:18:59 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 9 Oct 2013 17:18:59 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Wed, 9 Oct 2013 17:18:58 -0700 Message-ID: <5255F21A.1050100@codesourcery.com> Date: Thu, 10 Oct 2013 00:19:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Doug Evans CC: Joel Brobecker , gdb-patches Subject: Re: [PATCH 5/7] New lang-varobj.h References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-6-git-send-email-yao@codesourcery.com> <21068.21875.734416.904684@ruffy.mtv.corp.google.com> <20131008045901.GE3092@adacore.com> <5255EBB3.1050700@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00327.txt.bz2 On 10/10/2013 07:56 AM, Doug Evans wrote: > "Well ..." > > All it has is one struct, there's not much point to it right now. All right, I'll drop this patch. Probably we can revisit this patch when it is necessary to move. -- Yao (齐尧) P.S. I prefer to 'slice' sources having multiple modules and move each module into each single source file, even some file is quite simple.