Re: [RFA/code+NEWS] new "set/show serial baud" command (was: "Re: Setting parity for remote serial")

Doug Evans
2013-10-09T02:05:08Z

On Tue, Oct 8, 2013 at 7:16 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> > I'd rather we do it right the first time. If we're a go with
>> > the "set serial baud" command, I don't mind taking care of
>> > that part. As Pedro hints, it's a fairly easy change to make.
>> >
>> > Pedro, should we go ahead? It's only been a day or two, but we haven't
>> > had any objection so far.
>>
>> Yeah, I think so.
>
> Attached is a patch that implements that.
>
> gdb/ChangeLog:
>
> * cli/cli-cmds.c (show_baud_rate): Moved to serial.c as
> serial_baud_show_cmd.
> (_initialize_cli_cmds): Delete the code creating the
> "set/show remotebaud" commands.
> * serial.c (baud_rate): Move here from top.c.
> (serial_baud_show_cmd): Move here from cli/cli-cmds.c.
> (_initialize_serial): Create "set/show serial baud" commands.
> Add "set/show remotebaud" command aliases.
> * top.c (baud_rate): Moved to serial.c.
> * NEWS: Document the new "set/show serial baud" commands,
> replacing "set/show remotebaud".
>
> Tested on x86_64-linux, with no regression (I almost expected one,
> as we used to test thhe output "help set", or soemthing like that).
>
> OK to commit?
>
> Thanks,
> --
> Joel

+ /* The commands "set/show serial baud" used to have a different name.
+ Add aliases to those names to facilitate the transition. */
+ add_alias_cmd ("remotebaud", "serial baud", no_class, 0, &setlist);
+ add_alias_cmd ("remotebaud", "serial baud", no_class, 0, &showlist);

Does the mark-as-deprecated machinery work here?