From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23419 invoked by alias); 8 Oct 2013 13:36:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23409 invoked by uid 89); 8 Oct 2013 13:36:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Oct 2013 13:36:57 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VTXT3-0001MR-Lb from Taimoor_Mirza@mentor.com ; Tue, 08 Oct 2013 06:36:53 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 8 Oct 2013 06:36:53 -0700 Received: from [137.202.156.99] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 8 Oct 2013 14:36:51 +0100 Message-ID: <52540A71.9050702@mentor.com> Date: Tue, 08 Oct 2013 13:36:00 -0000 From: tmirza User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: "Abid, Hafiz" CC: Pedro Alves , Stan Shebs , "gdb-patches@sourceware.org" Subject: Re: [PATCH 0/7 V2] Trust readonly sections if target has memory protection References: <1378432920-7731-1-git-send-email-yao@codesourcery.com> <1378641807-24256-1-git-send-email-yao@codesourcery.com> <201309091916.r89JGbpf009986@glazunov.sibelius.xs4all.nl> <522E9A8A.7040509@codesourcery.com> <52317B66.3020602@codesourcery.com> <201309120949.r8C9nFsJ016506@glazunov.sibelius.xs4all.nl> <5232C9EC.2040707@codesourcery.com> <5249B9F9.4030901@redhat.com> <5249BE1C.5050907@redhat.com> <525335C0.8030004@earthlink.net> <5253F822.2090707@redhat.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00222.txt.bz2 On 10/08/2013 05:47 PM, Abid, Hafiz wrote: >> I distinctly remember reviewing this for the disassemble command, exactly >> as I was suggesting. I now recall better because I also hacked on the patch >> while iterating on multiple iterations of patch reviews. The change was >> contained to just gdb/disasm.c (or the gross of it at least), IIRC. >> Bleh, if we can't find it, we can always rewrite it. :-P. > Taimoor wrote a patch about disassembly improvement in April 2011. Pedro review this patch but I think it stayed in our internal repo and never went upstream. If there is interest, I can try to resurrect it. Yeah, I remember it very well as it was my first patch and Pedro helped me a lot. A cache based strategy was implemented to improve performance of disassembler.