From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2745 invoked by alias); 7 Oct 2013 22:29:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2732 invoked by uid 89); 7 Oct 2013 22:29:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: elasmtp-mealy.atl.sa.earthlink.net Received: from elasmtp-mealy.atl.sa.earthlink.net (HELO elasmtp-mealy.atl.sa.earthlink.net) (209.86.89.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Oct 2013 22:29:27 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-mealy.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1VTJIr-0005mE-Dt for gdb-patches@sourceware.org; Mon, 07 Oct 2013 18:29:25 -0400 Message-ID: <525335C0.8030004@earthlink.net> Date: Mon, 07 Oct 2013 22:29:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7 V2] Trust readonly sections if target has memory protection References: <1378432920-7731-1-git-send-email-yao@codesourcery.com> <1378641807-24256-1-git-send-email-yao@codesourcery.com> <201309091916.r89JGbpf009986@glazunov.sibelius.xs4all.nl> <522E9A8A.7040509@codesourcery.com> <52317B66.3020602@codesourcery.com> <201309120949.r8C9nFsJ016506@glazunov.sibelius.xs4all.nl> <5232C9EC.2040707@codesourcery.com> <5249B9F9.4030901@redhat.com> <5249BE1C.5050907@redhat.com> In-Reply-To: <5249BE1C.5050907@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9403cf0aa9765fa4667a71dcbcdb2aa0285350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00203.txt.bz2 On 9/30/13 11:08 AM, Pedro Alves wrote: > On 09/30/2013 06:50 PM, Pedro Alves wrote: > >> But in cases like disassembly, we're being driven by debug >> info or user input. As GDB knows upfront the whole range of memory it'll >> be fetching, accessing a bigger chunk upfront, as long as it doesn't >> step out of the range we read piecemeal anyway, should have no effect >> on correctness. > > Hmm, wait, I'm having a a déjà vu experience. I recalled I have > once reviewed a patch that does exactly this. But, I'm not finding > it in the tree, or in the archives. Maybe it was a CS local patch > that was never pushed? > There are a couple possibilities - for instance there we had a request to check that the code underneath a breakpoint had not changed behind our backs, or something like that. There was also the check of readonly areas for memory_xfer_partial reading from a traceframe, but that was your code, and it went into FSF in February 2011. :-) Stan stan@codesourcery.com