Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Thread-specific breakpoints: say "no longer in the thread list" instead of "gone". (was: [PATCH] [DOC] Mention what happens when the thread of a thread-specific breakpoint is gone.)
Date: Mon, 07 Oct 2013 11:03:00 -0000	[thread overview]
Message-ID: <52529509.7030700@redhat.com> (raw)
In-Reply-To: <83siwgc07r.fsf@gnu.org>

On 10/04/2013 08:20 PM, Eli Zaretskii wrote:

> Pedro Alves wrote:
>> Not sure whether GDB's own wording should be changed in the
>> same way?  This is 78 columns:
>>
>> -Thread-specific breakpoint 3 deleted - thread 28 is gone.
>> +Thread-specific breakpoint 3 deleted - thread 28 no longer in the thread list.
>>
>> It'll of course be larger with higher breakpoint and thread numbers, but
>> I guess it is still within reasonable bounds...
> 
> Maybe we should change the message wording as well; "gone" sounds
> awfully like "dead", which is inaccurate, and might even surprise the
> user if the thread actually simply exited.

OK, thanks.  I've applied a patch that changes GDB's wording like above.

---------
Thread-specific breakpoints: say "no longer in the thread list" instead of "gone".

It seems "gone" may confuse people, while that was exactly what it was
trying to avoid.  Switch to saying "no longer in the thread list",
which is really the predicate GDB uses.

gdb/
2013-10-07  Pedro Alves  <palves@redhat.com>

	PR breakpoints/11568
	* breakpoint.c (remove_threaded_breakpoints): Say "no longer in
	the thread list" instead of "gone".
---

 gdb/breakpoint.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index b98ca9e..d3e9e49 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -2943,7 +2943,7 @@ remove_threaded_breakpoints (struct thread_info *tp, int silent)
 	  b->disposition = disp_del_at_next_stop;
 
 	  printf_filtered (_("\
-Thread-specific breakpoint %d deleted - thread %d is gone.\n"),
+Thread-specific breakpoint %d deleted - thread %d no longer in the thread list.\n"),
 			  b->number, tp->num);
 
 	  /* Hide it from the user.  */


  reply	other threads:[~2013-10-07 11:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 15:01 [PATCH] [DOC] Mention what happens when the thread of a thread-specific breakpoint is gone Pedro Alves
2013-10-04 17:49 ` Eli Zaretskii
2013-10-04 17:54   ` Pedro Alves
2013-10-04 17:59     ` Pedro Alves
2013-10-04 18:26       ` Pedro Alves
2013-10-04 19:20         ` Eli Zaretskii
2013-10-07 11:03           ` Pedro Alves [this message]
2013-10-07 11:14           ` Pedro Alves
2013-10-04 18:14     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52529509.7030700@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox