From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA v2 05/24] Use gdb_file_up in source.c
Date: Sun, 30 Jul 2017 18:59:00 -0000 [thread overview]
Message-ID: <524eef6a9f646c9800b8b1a23dc12aca@polymtl.ca> (raw)
In-Reply-To: <20170725172107.9799-6-tom@tromey.com>
On 2017-07-25 19:20, Tom Tromey wrote:
> This changes some functions in source.c to use gdb_file_up.
>
> ChangeLog
> 2017-07-25 Tom Tromey <tom@tromey.com>
>
> * source.c (print_source_lines_base, forward_search_command)
> (reverse_search_command): Use gdb_file_up.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/source.c | 45 ++++++++++++++++-----------------------------
> 2 files changed, 21 insertions(+), 29 deletions(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index ab0a51f..4c23f79 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,10 @@
> 2017-07-25 Tom Tromey <tom@tromey.com>
>
> + * source.c (print_source_lines_base, forward_search_command)
> + (reverse_search_command): Use gdb_file_up.
> +
> +2017-07-25 Tom Tromey <tom@tromey.com>
> +
> * fbsd-nat.c (fbsd_find_memory_regions): Update.
>
> 2017-07-25 Tom Tromey <tom@tromey.com>
> diff --git a/gdb/source.c b/gdb/source.c
> index 8926e54..4cc862c 100644
> --- a/gdb/source.c
> +++ b/gdb/source.c
> @@ -1353,9 +1353,7 @@ print_source_lines_base (struct symtab *s, int
> line, int stopline,
> int c;
> int desc;
> int noprint = 0;
> - FILE *stream;
> int nlines = stopline - line;
> - struct cleanup *cleanup;
> struct ui_out *uiout = current_uiout;
>
> /* Regardless of whether we can open the file, set
> current_source_symtab. */
> @@ -1448,15 +1446,14 @@ print_source_lines_base (struct symtab *s, int
> line, int stopline,
> perror_with_name (symtab_to_filename_for_display (s));
> }
>
> - stream = fdopen (desc, FDOPEN_MODE);
> - clearerr (stream);
> - cleanup = make_cleanup_fclose (stream);
> + gdb_file_up stream (fdopen (desc, FDOPEN_MODE));
> + clearerr (stream.get ());
>
> while (nlines-- > 0)
> {
> char buf[20];
>
> - c = fgetc (stream);
> + c = fgetc (stream.get ());
> if (c == EOF)
> break;
> last_line_listed = current_source_line;
> @@ -1479,12 +1476,12 @@ print_source_lines_base (struct symtab *s, int
> line, int stopline,
> else if (c == '\r')
> {
> /* Skip a \r character, but only before a \n. */
> - int c1 = fgetc (stream);
> + int c1 = fgetc (stream.get ());
>
> if (c1 != '\n')
> printf_filtered ("^%c", c + 0100);
> if (c1 != EOF)
> - ungetc (c1, stream);
> + ungetc (c1, stream.get ());
> }
> else
> {
> @@ -1492,10 +1489,8 @@ print_source_lines_base (struct symtab *s, int
> line, int stopline,
> uiout->text (buf);
> }
> }
> - while (c != '\n' && (c = fgetc (stream)) >= 0);
> + while (c != '\n' && (c = fgetc (stream.get ())) >= 0);
> }
> -
> - do_cleanups (cleanup);
> }
> \f
> /* Show source lines from the file of symtab S, starting with line
> @@ -1630,7 +1625,6 @@ forward_search_command (char *regex, int
> from_tty)
> {
> int c;
> int desc;
> - FILE *stream;
> int line;
> char *msg;
> struct cleanup *cleanups;
> @@ -1659,9 +1653,8 @@ forward_search_command (char *regex, int
> from_tty)
> perror_with_name (symtab_to_filename_for_display
> (current_source_symtab));
>
> discard_cleanups (cleanups);
> - stream = fdopen (desc, FDOPEN_MODE);
> - clearerr (stream);
> - cleanups = make_cleanup_fclose (stream);
> + gdb_file_up stream (fdopen (desc, FDOPEN_MODE));
> + clearerr (stream.get ());
> while (1)
> {
> static char *buf = NULL;
> @@ -1672,7 +1665,7 @@ forward_search_command (char *regex, int
> from_tty)
> buf = (char *) xmalloc (cursize);
> p = buf;
>
> - c = fgetc (stream);
> + c = fgetc (stream.get ());
> if (c == EOF)
> break;
> do
> @@ -1686,7 +1679,7 @@ forward_search_command (char *regex, int
> from_tty)
> cursize = newsize;
> }
> }
> - while (c != '\n' && (c = fgetc (stream)) >= 0);
> + while (c != '\n' && (c = fgetc (stream.get ())) >= 0);
>
> /* Remove the \r, if any, at the end of the line, otherwise
> regular expressions that end with $ or \n won't work. */
> @@ -1701,7 +1694,6 @@ forward_search_command (char *regex, int
> from_tty)
> if (re_exec (buf) > 0)
> {
> /* Match! */
> - do_cleanups (cleanups);
> print_source_lines (current_source_symtab, line, line + 1, 0);
> set_internalvar_integer (lookup_internalvar ("_"), line);
> current_source_line = std::max (line - lines_to_list / 2, 1);
> @@ -1711,7 +1703,6 @@ forward_search_command (char *regex, int
> from_tty)
> }
>
> printf_filtered (_("Expression not found\n"));
> - do_cleanups (cleanups);
> }
>
> static void
> @@ -1719,7 +1710,6 @@ reverse_search_command (char *regex, int
> from_tty)
> {
> int c;
> int desc;
> - FILE *stream;
> int line;
> char *msg;
> struct cleanup *cleanups;
> @@ -1748,23 +1738,22 @@ reverse_search_command (char *regex, int
> from_tty)
> perror_with_name (symtab_to_filename_for_display
> (current_source_symtab));
>
> discard_cleanups (cleanups);
> - stream = fdopen (desc, FDOPEN_MODE);
> - clearerr (stream);
> - cleanups = make_cleanup_fclose (stream);
> + gdb_file_up stream (fdopen (desc, FDOPEN_MODE));
> + clearerr (stream.get ());
> while (line > 1)
> {
> /* FIXME!!! We walk right off the end of buf if we get a long line!!!
> */
> char buf[4096]; /* Should be reasonable??? */
> char *p = buf;
>
> - c = fgetc (stream);
> + c = fgetc (stream.get ());
> if (c == EOF)
> break;
> do
> {
> *p++ = c;
> }
> - while (c != '\n' && (c = fgetc (stream)) >= 0);
> + while (c != '\n' && (c = fgetc (stream.get ())) >= 0);
>
> /* Remove the \r, if any, at the end of the line, otherwise
> regular expressions that end with $ or \n won't work. */
> @@ -1779,25 +1768,23 @@ reverse_search_command (char *regex, int
> from_tty)
> if (re_exec (buf) > 0)
> {
> /* Match! */
> - do_cleanups (cleanups);
> print_source_lines (current_source_symtab, line, line + 1, 0);
> set_internalvar_integer (lookup_internalvar ("_"), line);
> current_source_line = std::max (line - lines_to_list / 2, 1);
> return;
> }
> line--;
> - if (fseek (stream, current_source_symtab->line_charpos[line -
> 1], 0) < 0)
> + if (fseek (stream.get (),
> + current_source_symtab->line_charpos[line - 1], 0) < 0)
> {
> const char *filename;
>
> - do_cleanups (cleanups);
> filename = symtab_to_filename_for_display (current_source_symtab);
> perror_with_name (filename);
> }
> }
>
> printf_filtered (_("Expression not found\n"));
> - do_cleanups (cleanups);
> return;
> }
LGTM.
next prev parent reply other threads:[~2017-07-30 18:59 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 17:24 [RFA v2 00/24] More miscellaneous C++-ification Tom Tromey
2017-07-25 17:21 ` [RFA v2 22/24] Introduce gdb_argv, a class wrapper for buildargv Tom Tromey
2017-07-31 20:22 ` Simon Marchi
2017-07-25 17:21 ` [RFA v2 18/24] Use a scoped_restore for command_nest_depth Tom Tromey
2017-07-25 17:21 ` [RFA v2 19/24] Replace do_restore_instream_cleanup with scoped_restore Tom Tromey
2017-07-25 17:21 ` [RFA v2 23/24] Use gdb_argv in Python Tom Tromey
2017-07-31 20:26 ` Simon Marchi
2017-07-25 17:22 ` [RFA v2 05/24] Use gdb_file_up in source.c Tom Tromey
2017-07-30 18:59 ` Simon Marchi [this message]
2017-07-25 17:22 ` [RFA v2 12/24] More uses of scoped_restore Tom Tromey
2017-07-25 17:22 ` [RFA v2 16/24] Remove in_user_command Tom Tromey
2017-07-25 17:24 ` [RFA v2 06/24] Change open_terminal_stream to return a gdb_file_up Tom Tromey
2017-07-30 19:04 ` Simon Marchi
2017-07-25 17:24 ` [RFA v2 09/24] Remove close cleanup Tom Tromey
2017-07-31 19:09 ` Simon Marchi
2017-07-25 17:24 ` [RFA v2 08/24] Remove an unlink cleanup Tom Tromey
2017-07-31 18:47 ` Simon Marchi
2017-07-25 17:24 ` [RFA v2 24/24] Remove make_cleanup_freeargv and gdb_buildargv Tom Tromey
2017-07-31 20:26 ` Simon Marchi
2017-07-25 17:25 ` [RFA v2 10/24] Remove make_cleanup_restore_current_language Tom Tromey
2017-07-31 19:21 ` Simon Marchi
2017-07-31 22:17 ` Tom Tromey
2017-08-01 8:44 ` Simon Marchi
2017-07-25 17:26 ` [RFA v2 01/24] Introduce and use ui_out_emit_table Tom Tromey
2017-07-29 23:10 ` Simon Marchi
2017-07-30 16:23 ` Tom Tromey
2017-07-30 18:29 ` Simon Marchi
2017-07-31 22:12 ` Tom Tromey
2017-07-25 17:26 ` [RFA v2 07/24] Remove make_cleanup_fclose Tom Tromey
2017-07-30 19:05 ` Simon Marchi
2017-07-25 17:26 ` [RFA v2 21/24] Remove a cleanup in Python Tom Tromey
2017-07-25 17:26 ` [RFA v2 04/24] Use gdb_file_up in fbsd-nat.c Tom Tromey
2017-07-29 23:56 ` Simon Marchi
2017-07-25 17:26 ` [RFA v2 02/24] Introduce and use gdb_file_up Tom Tromey
2017-07-29 23:40 ` Simon Marchi
2017-07-30 16:25 ` Tom Tromey
2017-07-30 18:31 ` Simon Marchi
2017-07-25 17:27 ` [RFA v2 14/24] Use unique_xmalloc_ptr in jit.c Tom Tromey
2017-07-31 19:25 ` Simon Marchi
2017-07-25 17:27 ` [RFA v2 15/24] Use containers to avoid cleanups Tom Tromey
2017-07-31 19:42 ` Simon Marchi
2017-07-25 17:27 ` [RFA v2 13/24] Replace tui_restore_gdbout with scoped_restore Tom Tromey
2017-07-25 17:27 ` [RFA v2 03/24] Change return type of find_and_open_script Tom Tromey
2017-07-29 23:54 ` Simon Marchi
2017-07-30 16:27 ` Tom Tromey
2017-07-25 17:51 ` [RFA v2 20/24] Avoid some manual memory management in Python Tom Tromey
2017-07-25 18:02 ` [RFA v2 17/24] Remove user_call_depth Tom Tromey
2017-07-31 19:46 ` Simon Marchi
2017-07-25 18:04 ` [RFA v2 11/24] Remove make_cleanup_free_so Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524eef6a9f646c9800b8b1a23dc12aca@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox