From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5900 invoked by alias); 2 Oct 2013 10:48:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5889 invoked by uid 89); 2 Oct 2013 10:48:31 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Oct 2013 10:48:31 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r92AmRCH013504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Oct 2013 06:48:27 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r92AmQbN018376; Wed, 2 Oct 2013 06:48:27 -0400 Message-ID: <524BF9FA.6010208@redhat.com> Date: Wed, 02 Oct 2013 10:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Move notif_queue to remote_state References: <1376877311-4135-1-git-send-email-yao@codesourcery.com> <1376877311-4135-2-git-send-email-yao@codesourcery.com> <52430B69.4090301@redhat.com> <5249293D.8050700@codesourcery.com> <5249B011.1080207@redhat.com> <524B7C65.3030005@codesourcery.com> In-Reply-To: <524B7C65.3030005@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00089.txt.bz2 On 10/02/2013 02:52 AM, Yao Qi wrote: > On 10/01/2013 01:08 AM, Pedro Alves wrote: >>> -static void >>>> -notif_xfree (struct notif_client *notif) >> ... >>>> - if (notif->pending_event != NULL >>>> - && notif->pending_event->dtr != NULL) >>>> - notif->pending_event->dtr (notif->pending_event); >> Hmm, it's not clear to me from reading the patch where is >> pending_event released after this patch. Could you help >> me understand that? > > Since notif_queue is a global variable, we've never used QUEUE_free to > free notif_queue, so notif_xfree is never called, and pending_event on > each notif_client is not released. > > When we move notif_queue to 'remote_notif_state', we have to explicitly > use QUEUE_free to free notif_queue and elements in it. We put the > pointer of each notif_client to notif_queue, so we don't need a function > to free the notif_client when notif_queue is destroyed. So the > notif_queue is allocated like this, > > notif_state->notif_queue = QUEUE_alloc (notif_client_p, NULL); > > and notif_xfree is not needed any more. The leak on pending_event is > still there, but it is fixed by the next patch, which moves > pending_event to remote_notif_state, and pending_event is freed in > remote_notif_state_xfree. I see now, thanks. BTW: +struct remote_notif_state +{ + /* Notification queue. */ + QUEUE(notif_client_p) *notif_queue; + + /* Asynchronous signal handle registered as event loop source for when + the remote sent us a notification. The registered callback + will do a ACK sequence to pull the rest of the events out of + the remote side into our event queue. */ + + struct async_event_handler *remote_async_get_pending_events_token; Since remote_async_get_pending_events_token is no longer a global, it doesn't need the "remote_" prefix (or even remote_async_?) anymore. WDYT? The patch is OK with or without that change. Thanks, -- Pedro Alves