From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32147 invoked by alias); 1 Oct 2013 13:34:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32132 invoked by uid 89); 1 Oct 2013 13:34:31 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 13:34:31 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VR05q-00038O-O1 from Yao_Qi@mentor.com ; Tue, 01 Oct 2013 06:34:26 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 1 Oct 2013 06:34:26 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Tue, 1 Oct 2013 06:34:25 -0700 Message-ID: <524ACF04.2050904@codesourcery.com> Date: Tue, 01 Oct 2013 13:34:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH 2/7] Remove vlang_unknown References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-3-git-send-email-yao@codesourcery.com> <20131001100742.GC2840@adacore.com> In-Reply-To: <20131001100742.GC2840@adacore.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00047.txt.bz2 On 10/01/2013 06:07 PM, Joel Brobecker wrote: > I am not really sure why the first enum would need to be zero. > If we cannot find an answer to that question, I propose you leave > the "= 0" out of this patch. In varobj.c:varobj_create, variable_language returns 'enum varobj_languages', and use it as an index to array languages. /* Set language info */ lang = variable_language (var); var->root->lang = &languages[lang]; that is the reason the first enum should be zero. -- Yao (齐尧)