From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28622 invoked by alias); 1 Oct 2013 09:35:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28608 invoked by uid 89); 1 Oct 2013 09:35:09 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 09:35:09 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r919Z5gK023808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 1 Oct 2013 05:35:05 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r919Z3wB000883; Tue, 1 Oct 2013 05:35:04 -0400 Message-ID: <524A9747.7030501@redhat.com> Date: Tue, 01 Oct 2013 09:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] New function windows_init_abi References: <1378641807-24256-1-git-send-email-yao@codesourcery.com> <1379645226-8719-1-git-send-email-yao@codesourcery.com> <1379645226-8719-4-git-send-email-yao@codesourcery.com> <5249C19D.6060601@redhat.com> <524A6FBF.2090901@codesourcery.com> In-Reply-To: <524A6FBF.2090901@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00019.txt.bz2 On 10/01/2013 07:46 AM, Yao Qi wrote: > On 10/01/2013 02:23 AM, Pedro Alves wrote: >> arm-wince-pe.c:arm_wince_init_abi should call windows_init_abi too. >> That fact that that doesn't call >> set_gdbarch_iterate_over_objfiles_in_search_order today looks like >> exactly the sort of issue that a patch like this one would prevent. > > windows-tdep.o is not linked for arm-wince-pe target. In > configure.target: > > arm*-wince-pe | arm*-*-mingw32ce*) > # Target: ARM based machine running Windows CE (win32) > gdb_target_obs="arm-tdep.o arm-wince-tdep.o" > build_gdbserver=yes > > I am not sure the TIB stuff in windows-tdep.c can be applicable to ARM > wince target. It was discussed in the review to the patch > > [RFC-v2] Add windows Thread Information Block > https://sourceware.org/ml/gdb-patches/2009-07/msg00010.html > > windows-tdep.c looks quite target-independent, except some comments, > in which "fs" and "gs" is mentioned. How about this patch below? Yeah, %fs and %gs of course are only applicable to x86/amd64. I don't recall if the TIB structure on x86 WinCE is the same as the x86 desktop Windows , and/or whether the ARM/x86 WinCE versions have the same layout (ISTR not), or even what's the story for the new ARM WinRT (which I'm assuming will a GDB port to soon enough). In any case, it's windows_get_tlb_type that will probably need to evolve and be moved to arch tdep files. Making all the Windows builds link in windows-tdep.c is definitely the correct thing to do. > windows-tdep.o is linked in target arm*-wince-pe and > arm*-*-mingw32ce*, supposing set_solib_ops has been moved to > windows_init_abi. >> >> The patch looks OK to me with that change. >> >> ['set_solib_ops (gdbarch, &solib_target_so_ops)' should be able to >> move to windows_init_abi too.] > > OK. I'll move it to windows_init_abi in the updated patch. > > - /* Shared library handling. */ Leave this one. "skip_trampoline_code" is also related to shared library handling. > - set_solib_ops (gdbarch, &solib_target_so_ops); > set_gdbarch_skip_trampoline_code (gdbarch, arm_pe_skip_trampoline_code); Otherwise OK. Thanks! -- Pedro Alves