From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13776 invoked by alias); 1 Oct 2013 06:47:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13767 invoked by uid 89); 1 Oct 2013 06:47:56 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 06:47:56 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VQtkM-00074W-6l from Yao_Qi@mentor.com ; Mon, 30 Sep 2013 23:47:50 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 30 Sep 2013 23:47:49 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Mon, 30 Sep 2013 23:47:49 -0700 Message-ID: <524A6FBF.2090901@codesourcery.com> Date: Tue, 01 Oct 2013 06:47:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 3/7] New function windows_init_abi References: <1378641807-24256-1-git-send-email-yao@codesourcery.com> <1379645226-8719-1-git-send-email-yao@codesourcery.com> <1379645226-8719-4-git-send-email-yao@codesourcery.com> <5249C19D.6060601@redhat.com> In-Reply-To: <5249C19D.6060601@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00010.txt.bz2 On 10/01/2013 02:23 AM, Pedro Alves wrote: > arm-wince-pe.c:arm_wince_init_abi should call windows_init_abi too. > That fact that that doesn't call > set_gdbarch_iterate_over_objfiles_in_search_order today looks like > exactly the sort of issue that a patch like this one would prevent. windows-tdep.o is not linked for arm-wince-pe target. In configure.target: arm*-wince-pe | arm*-*-mingw32ce*) # Target: ARM based machine running Windows CE (win32) gdb_target_obs="arm-tdep.o arm-wince-tdep.o" build_gdbserver=yes I am not sure the TIB stuff in windows-tdep.c can be applicable to ARM wince target. It was discussed in the review to the patch [RFC-v2] Add windows Thread Information Block https://sourceware.org/ml/gdb-patches/2009-07/msg00010.html windows-tdep.c looks quite target-independent, except some comments, in which "fs" and "gs" is mentioned. How about this patch below? windows-tdep.o is linked in target arm*-wince-pe and arm*-*-mingw32ce*, supposing set_solib_ops has been moved to windows_init_abi. > > The patch looks OK to me with that change. > > ['set_solib_ops (gdbarch, &solib_target_so_ops)' should be able to > move to windows_init_abi too.] OK. I'll move it to windows_init_abi in the updated patch. -- Yao (齐尧) gdb: 2013-10-01 Yao Qi * arm-wince-tdep.c: Remove inclusion of "solib.h" and "solib-target.h". Include "windows-tdep.h". (arm_wince_init_abi): Call windows_init_abi. Remove call to set_solib_ops and set_gdbarch_has_dos_based_file_system. * configure.tgt (arm*-wince-pe | arm*-*-mingw32ce*): Append windows-tdep.o to gdb_target_obs. --- gdb/arm-wince-tdep.c | 11 +++-------- gdb/configure.tgt | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/gdb/arm-wince-tdep.c b/gdb/arm-wince-tdep.c index 61569e3..163ec73 100644 --- a/gdb/arm-wince-tdep.c +++ b/gdb/arm-wince-tdep.c @@ -22,13 +22,12 @@ #include "osabi.h" #include "gdbcore.h" #include "target.h" -#include "solib.h" -#include "solib-target.h" #include "frame.h" #include "gdb_string.h" #include "arm-tdep.h" +#include "windows-tdep.h" static const gdb_byte arm_wince_le_breakpoint[] = { 0x10, 0x00, 0x00, 0xe6 }; static const gdb_byte arm_wince_thumb_le_breakpoint[] = { 0xfe, 0xdf }; @@ -116,6 +115,8 @@ arm_wince_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + windows_init_abi (info, gdbarch); + tdep->arm_breakpoint = arm_wince_le_breakpoint; tdep->arm_breakpoint_size = sizeof (arm_wince_le_breakpoint); tdep->thumb_breakpoint = arm_wince_thumb_le_breakpoint; @@ -130,8 +131,6 @@ arm_wince_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) /* On ARM WinCE char defaults to signed. */ set_gdbarch_char_signed (gdbarch, 1); - /* Shared library handling. */ - set_solib_ops (gdbarch, &solib_target_so_ops); set_gdbarch_skip_trampoline_code (gdbarch, arm_pe_skip_trampoline_code); /* Single stepping. */ @@ -139,10 +138,6 @@ arm_wince_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) /* Skip call to __gccmain that gcc places in main. */ set_gdbarch_skip_main_prologue (gdbarch, arm_wince_skip_main_prologue); - - /* Canonical paths on this target look like `\Windows\coredll.dll', - for example. */ - set_gdbarch_has_dos_based_file_system (gdbarch, 1); } static enum gdb_osabi diff --git a/gdb/configure.tgt b/gdb/configure.tgt index 95c7217..ea0faf1 100644 --- a/gdb/configure.tgt +++ b/gdb/configure.tgt @@ -83,7 +83,7 @@ am33_2.0*-*-linux*) arm*-wince-pe | arm*-*-mingw32ce*) # Target: ARM based machine running Windows CE (win32) - gdb_target_obs="arm-tdep.o arm-wince-tdep.o" + gdb_target_obs="arm-tdep.o arm-wince-tdep.o windows-tdep.o" build_gdbserver=yes ;; arm*-*-linux*) -- 1.7.7.6