From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21990 invoked by alias); 1 Oct 2013 01:19:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21979 invoked by uid 89); 1 Oct 2013 01:19:32 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 01:19:32 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r911JSbt001889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Sep 2013 21:19:28 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r911JRdP005710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 Sep 2013 21:19:28 -0400 Message-ID: <524A231F.1050101@redhat.com> Date: Tue, 01 Oct 2013 01:19:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller CC: "'gdb-patches'" Subject: Re: [RFC 5/6] Handle "set print sevenbit-strings on" in print_wchar References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <003801cebaf3$888993e0$999cbba0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <003801cebaf3$888993e0$999cbba0$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00003.txt.bz2 On 09/26/2013 01:03 PM, Pierre Muller wrote: > 2013-09-26 Pierre Muller > > valprint.c (print_wchar): Honor sevenbit_strings value. > [Your ChangeLog entry got munged...] I would prefer that you ChangeLog entry be a little more explicit about what changed, e.g., "Print escaped characters if sevenbit-strings is set." I think this patch is okay, but it definitely needs a test (and a maintainer to approve). It took me a non-trivial amount of time to actually get the patch to show any difference in the output. The trick (on linux) was changing the charset to something where (char)0x80 and up are printable characters. I used CP1252, and then I could see what this patch actually did. Perhaps this can be used in a test that will run on more than just MinGW hosts. Keith