From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30698 invoked by alias); 30 Sep 2013 18:23:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30683 invoked by uid 89); 30 Sep 2013 18:23:30 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2013 18:23:30 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8UINR6p020135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Sep 2013 14:23:27 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r8UINPf8008228; Mon, 30 Sep 2013 14:23:26 -0400 Message-ID: <5249C19D.6060601@redhat.com> Date: Mon, 30 Sep 2013 18:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] New function windows_init_abi References: <1378641807-24256-1-git-send-email-yao@codesourcery.com> <1379645226-8719-1-git-send-email-yao@codesourcery.com> <1379645226-8719-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1379645226-8719-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg01015.txt.bz2 On 09/20/2013 03:47 AM, Yao Qi wrote: > 2013-09-08 Yao Qi > > * amd64-windows-tdep.c (amd64_windows_init_abi): Don't call > set_gdbarch_iterate_over_objfiles_in_search_order. Call > windows_init_abi instead. > * i386-cygwin-tdep.c (i386_cygwin_init_abi): Don't call > set_gdbarch_has_dos_based_file_system and > set_gdbarch_iterate_over_objfiles_in_search_order. Call > windows_init_abi instead. > * windows-tdep.c (windows_init_abi): New function. > (windows_iterate_over_objfiles_in_search_order): Make it > static. > * windows-tdep.h (windows_init_abi): Declare. > (windows_iterate_over_objfiles_in_search_order): Remove > declaration. This looks like a good idea on its own, and could go in independently of the rest of the series. arm-wince-pe.c:arm_wince_init_abi should call windows_init_abi too. That fact that that doesn't call set_gdbarch_iterate_over_objfiles_in_search_order today looks like exactly the sort of issue that a patch like this one would prevent. The patch looks OK to me with that change. ['set_solib_ops (gdbarch, &solib_target_so_ops)' should be able to move to windows_init_abi too.] -- Pedro Alves