From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16776 invoked by alias); 27 Sep 2013 08:07:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16756 invoked by uid 89); 27 Sep 2013 08:07:23 -0000 Received: from mail-pb0-f50.google.com (HELO mail-pb0-f50.google.com) (209.85.160.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 27 Sep 2013 08:07:23 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=4.0 required=5.0 tests=ALL_TRUSTED,BAYES_05,FREEMAIL_FROM,SPAM_SUBJECT autolearn=no version=3.3.2 X-HELO: mail-pb0-f50.google.com Received: by mail-pb0-f50.google.com with SMTP id uo5so2258441pbc.9 for ; Fri, 27 Sep 2013 01:07:21 -0700 (PDT) X-Received: by 10.68.197.104 with SMTP id it8mr5826568pbc.17.1380269241276; Fri, 27 Sep 2013 01:07:21 -0700 (PDT) Received: from [192.168.1.100] ([115.199.125.136]) by mx.google.com with ESMTPSA id sz3sm7042945pbc.36.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 27 Sep 2013 01:07:20 -0700 (PDT) Message-ID: <52453E5C.4070704@gmail.com> Date: Fri, 27 Sep 2013 08:07:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Pierre Muller , 'gdb-patches' Subject: Re: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off" command. References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <33207.6293569573$1380225714@news.gmane.org> In-Reply-To: <33207.6293569573$1380225714@news.gmane.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00950.txt.bz2 On 2013-9-27 4:01, Pierre Muller wrote: > This patch is to add > maint set testsuite mode on/off > command. > Finally, thanks to Yao's patch about handling of flushing of > stderr for mingw, it reduces to switching the > stdout and stderr between binary and text mode. > [SKIP] > > --- > gdb/mingw-hdep.c | 58 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 58 insertions(+), 0 deletions(-) > > diff --git a/gdb/mingw-hdep.c b/gdb/mingw-hdep.c > index 976e9e8..330f46b 100644 > --- a/gdb/mingw-hdep.c > +++ b/gdb/mingw-hdep.c > @@ -21,6 +21,8 @@ > #include "main.h" > #include "serial.h" > #include "event-loop.h" > +#include "command.h" > +#include "gdbcmd.h" > > #include "gdb_assert.h" > #include "gdb_select.h" > @@ -274,6 +276,50 @@ gdb_call_async_signal_handler (struct > async_signal_handler *handler, > SetEvent (sigint_event); > } > I failed to apply this patch: Here is the log: zyh23@ZYH /f/build_gdb/gdb/gdbgit/gdb (my_build) $ git am ../patches/muller/*.eml Applying: Fix display of tabulation character for mingw hosts. Applying: Avoid missing char before incomplete sequence in wchar_iterate. Applying: mingw-hdep: Add "maint set testuite-mode on/off" command. fatal: corrupt patch at line 20 Patch failed at 0003 mingw-hdep: Add "maint set testuite-mode on/off" command. The copy of the patch that failed is found in: f:/build_gdb/gdb/gdbgit/gdb/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". I just look at the line around 274, it is: .... void gdb_call_async_signal_handler (struct async_signal_handler *handler, int immediate_p) { if (immediate_p) sigint_handler = handler; else { mark_async_signal_handler (handler); sigint_handler = NULL; } SetEvent (sigint_event); } /* -Wmissing-prototypes */ extern initialize_file_ftype _initialize_mingw_hdep; ..... So, I can't find the line in your patch > @@ -274,6 +276,50 @@ gdb_call_async_signal_handler (struct > async_signal_handler *handler, Oh, I found that this line (function name and its parameter get wrapped).... I fix those kind of errors by manually editing those eml files. Besides that, the last patch, I see the email title have a CRLF after the word "PATCH", so when applied, I see the log message is lost. So, Sending those patches as attachment should not have such problem. Thanks Yuanhui Zhang