From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26322 invoked by alias); 26 Sep 2013 18:43:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26308 invoked by uid 89); 26 Sep 2013 18:43:23 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2013 18:43:23 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPAM_SUBJECT autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8QIhFDi011415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Sep 2013 14:43:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8QIhDo7031453; Thu, 26 Sep 2013 14:43:14 -0400 Message-ID: <52448041.3070703@redhat.com> Date: Thu, 26 Sep 2013 18:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] Add annex in an async remote notification. References: <1376877311-4135-1-git-send-email-yao@codesourcery.com> <1376877311-4135-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1376877311-4135-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00934.txt.bz2 Hi Yao, On 08/19/2013 02:55 AM, Yao Qi wrote: > In order to support "Trace:status" notification and other similar > usage (such as "Point:modified", about a breakpoint is modified), we > introduce "annex" in the async remote notification, which is helpful > to give us more details what the contents about in the async remote > notification. The annex in each notification is optional. In the > RSP: Please help me understand this, as it's not obvious to me. This mechanism adds a bunch of new code. I've read the series and the descriptions a few times, and I still haven't managed to find where the rationale behind these annexes is (or figure it out myself). :-( _Why_ are they necessary? What problem do they solve, that simply calling these notifications "Trace-status", "Point-modified", and later other new notifications "Trace-whatever-else", "Point-whatnot", etc. wouldn't solve? If it's just neat grouping, than it doesn't look like worthwhile. The only thing that comes to mind is ordering -- that is, all event with the same base notification handled on a FIFO basis, even if they have different annexes. But that doesn't look like to be the reason -- given that the other annex hinted -- Point:modified -- belongs to a different notification. -- Pedro Alves