From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9636 invoked by alias); 22 Sep 2013 02:54:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9610 invoked by uid 89); 22 Sep 2013 02:54:25 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Sep 2013 02:54:25 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VNZoS-00042F-QW from Yao_Qi@mentor.com ; Sat, 21 Sep 2013 19:54:20 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 21 Sep 2013 19:54:21 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Sat, 21 Sep 2013 19:54:19 -0700 Message-ID: <523E5BB8.1080406@codesourcery.com> Date: Sun, 22 Sep 2013 02:54:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches Subject: Re: [RFC 2/3] Perf test framework References: <520B7F70.6070207@codesourcery.com> <1377663394-4975-1-git-send-email-yao@codesourcery.com> <1377663394-4975-3-git-send-email-yao@codesourcery.com> <21051.19430.251374.942418@ruffy.mtv.corp.google.com> <523C015E.30902@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00792.txt.bz2 On 09/21/2013 12:51 AM, Doug Evans wrote: >> I was wondering that we can support json format, so I create class >> >PerfTestConfig and perftest.ini is used to determine which format to >> >be used. I agree that we can remove PerfTestConfig since we >> >only support only one format (plain text) nowadays. > Hi. I wasn't suggesting removing support for more reporting formats. > We'll be adding our own.:-) > > I'm just wondering, if all that pertest.ini will contain is the report > format, do we need it? perftest.ini only contains report format so far, but the perf test framework needs more and more customizations, so perftest.ini will contain more stuffs. > Or, can we specify the format (and whatever else is desired/needed) > via some other means? by env var? I thought of this, but this doesn't scale to me, if we have more to set. > How will the user specify the desired report format? > in testsuite/perftest.ini [Reporter] type = TextReporter In short, we don't have anything to customize in perf test, so I am OK to remove PerfTestConfig. Once we want to do customization, I still prefer to do it through config file, like perftest.ini. -- Yao (齐尧)