RE: [PATCH] Fix PR server/15959

Agovic, Sanimir
2013-09-17T07:11:43Z

This look good to me (though it is not an approval)

Some minor comments below.

-Sanimir

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Yao Qi
> Sent: Tuesday, September 17, 2013 06:13 AM
> To: gdb-patches@sourceware.org
> Subject: [PATCH] Fix PR server/15959
>
> diff --git a/gdb/testsuite/gdb.server/wrapper.c b/gdb/testsuite/gdb.server/wrapper.c
> new file mode 100644
> index 0000000..75e8c1d
> --- /dev/null
> +++ b/gdb/testsuite/gdb.server/wrapper.c
> @@ -0,0 +1,35 @@
> +/* This testcase is part of GDB, the GNU debugger.
> +
> + Copyright 2013 Free Software Foundation, Inc.
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 3 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program. If not, see <http://www.gnu.org/licenses/>. */
> +
> +#include <stdio.h>
>
Seems this header is not needed.

> diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
> new file mode 100644
> index 0000000..ee2e430
> --- /dev/null
> +++ b/gdb/testsuite/gdb.server/wrapper.exp
> @@ -0,0 +1,48 @@
> [...]
> +
> +if { [skip_gdbserver_tests] } {
> + return 0
> +}
>
Here you use space around the condition, below you don't. At least we should be consistent.
>
> +
> +if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
> + return -1
> +}
> +

> +gdb_test "continue" "Breakpoint.* marker .*" "continue to marker"
> +# Test env var TEST is correctly passed to the program through
> +# --wrapper.
> +gdb_test "p d" "\\$${decimal} = ${hex} \"1\".*"
>
For the sake of maintenance I prefer full spelled commands "p d" vs. "print d". But
this is a matter of taste, so no action is required.

-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052