Re: [PATCH] Fix PR server/15959

Pedro Alves
2013-09-17T15:57:56Z

Thanks Yao.

On 09/17/2013 10:18 AM, Yao Qi wrote:

> +static void
> +marker (void)
> +{}
> +
> +int
> +main(void)

Missing space after parens (you added it in "marker").

> +{
> + d = getenv("TEST");

Here too.

> +
> + marker ();
> +
> + return 0;
> +}

I think the test will fail on Windows, because there's no
"env" binary there. I think we should first try to see
if running "env" works, with "remote_exec target", and
mark the test UNSUPPORTED if it doesn't.

Otherwise it looks good to me.

--
Pedro Alves