From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5440 invoked by alias); 17 Sep 2013 14:06:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5431 invoked by uid 89); 17 Sep 2013 14:06:38 -0000 Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 17 Sep 2013 14:06:38 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_VIA_APNIC,RDNS_LOCALHOST autolearn=no version=3.3.2 X-HELO: USMAMAIL.TILERA.COM Received: from localhost.localdomain (124.193.190.225) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server (TLS) id 14.0.722.0; Tue, 17 Sep 2013 10:06:34 -0400 Message-ID: <523861E3.1090402@tilera.com> Date: Tue, 17 Sep 2013 14:06:00 -0000 From: Jiong Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: [COMMITTED][RFC/TileGX 2/2] fix gdbserver runtime crash References: <50F9148F.3010602@tilera.com> <5237C847.3040908@tilera.com> <5237CB65.4000703@tilera.com> <20130917123304.GE3132@adacore.com> <52384D8E.4010009@tilera.com> <52385794.1060307@tilera.com> <20130917132855.GF3132@adacore.com> In-Reply-To: <20130917132855.GF3132@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00514.txt.bz2 On 09/17/2013 09:28 PM, Joel Brobecker wrote: >>> it's a complicated story and my fault. >>> >>> we use Perforce to manage code within the company. This bug is >>> fixed by Jeff (previous maintainer of TileGX gdb) long time ago in >>> Perforce, but he >>> didn't commit it to community. And we mainly test binaries >>> generated from our Perforce. >>> >>> I should be more careful when I check dejagnu test result when >>> submit to community :) > No worries, here, just trying to understand the full story. > >> is this OK to commit? > Yes. committed. 2013-09-16 Jiong Wang * linux-tile-low.c (tile_regsets): Modify the size field to 64-bit for each register. =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/linux-tile-low.c,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- src/gdb/gdbserver/linux-tile-low.c 2013/06/07 10:46:59 1.4 +++ src/gdb/gdbserver/linux-tile-low.c 2013/09/17 14:00:30 1.5 @@ -124,7 +124,7 @@ static struct regset_info tile_regsets[] = { - { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4, + { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8, GENERAL_REGS, tile_fill_gregset, tile_store_gregset }, { 0, 0, 0, -1, -1, NULL, NULL } }; > >>>>> diff --git a/gdb/gdbserver/linux-tile-low.c >>>>> b/gdb/gdbserver/linux-tile-low.c >>>>> index 8963b9a..8efb34e 100644 >>>>> --- a/gdb/gdbserver/linux-tile-low.c >>>>> +++ b/gdb/gdbserver/linux-tile-low.c >>>>> @@ -124,7 +124,7 @@ tile_store_gregset (struct regcache >>>>> *regcache, const void *buf) >>>>> static struct regset_info tile_regsets[] = >>>>> { >>>>> - { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4, >>>>> + { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8, >>>>> GENERAL_REGS, tile_fill_gregset, tile_store_gregset }, >>>>> { 0, 0, 0, -1, -1, NULL, NULL } >>>>> };