From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3474 invoked by alias); 17 Sep 2013 14:04:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3461 invoked by uid 89); 17 Sep 2013 14:04:52 -0000 Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 17 Sep 2013 14:04:52 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_VIA_APNIC,RDNS_LOCALHOST autolearn=no version=3.3.2 X-HELO: USMAMAIL.TILERA.COM Received: from localhost.localdomain (124.193.190.225) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server (TLS) id 14.0.722.0; Tue, 17 Sep 2013 10:04:48 -0400 Message-ID: <52386179.7060704@tilera.com> Date: Tue, 17 Sep 2013 14:04:00 -0000 From: Jiong Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: [COMMITTED][RFC/TileGX 1/2] fix gdbserver build failure References: <50F9148F.3010602@tilera.com> <5237C847.3040908@tilera.com> <20130917123042.GD3132@adacore.com> <52384C0E.1070808@tilera.com> <5238574F.1000509@tilera.com> <20130917133023.GG3132@adacore.com> <52385AEF.5070404@tilera.com> <20130917134309.GI3132@adacore.com> In-Reply-To: <20130917134309.GI3132@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00512.txt.bz2 On 09/17/2013 09:43 PM, Joel Brobecker wrote: >> linux-tile-low.o is the target file of TileGX. (it's name is confusing ?) >> >> previous commit by the following wrongly removed the tilegx target file. >> >> commit f7fc28008a4d76dd6e55eb77070eb18e956406a9 >> Author: Luis Machado >> Date: Thu Aug 22 23:46:27 2013 +0000 >> >> - srv_tgtobj="linux-low.o linux-tile-low.o linux-osdata.o linux-procfs.o" >> - srv_tgtobj="${srv_tgtobj} linux-ptrace.o" >> + srv_tgtobj="$srv_linux_obj linux-osdata.o" > Ok. Thank you for that, I had missed that commit in my research. > That goes to show how important it is to send detailed descriptions > of the problem when sending a patch. Otherwise, we end up wasting > time trying to figure it out again. > > I knew what the file was about, and I knew it made sense. But I'd like > every patch to be explained on this list before it gets checked in. > This is for later on, when someone tries to figure out why a patch > was applied, at least it's documented in one public place. understand. thanks for careful review. commited. 2013-09-16 Jiong Wang * configure.srv : Remove linux-osdata.o from and add linux-tile-low.o to srv_tgtobj. =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v retrieving revision 1.79 retrieving revision 1.80 diff -u -r1.79 -r1.80 --- src/gdb/gdbserver/configure.srv 2013/09/13 14:17:30 1.79 +++ src/gdb/gdbserver/configure.srv 2013/09/17 13:56:54 1.80 @@ -340,7 +340,7 @@ ;; tilegx-*-linux*) srv_regobj=reg-tilegx.o srv_regobj="${srv_regobj} reg-tilegx32.o" - srv_tgtobj="$srv_linux_obj linux-osdata.o" + srv_tgtobj="$srv_linux_obj linux-tile-low.o" srv_linux_regsets=yes srv_linux_thread_db=yes ;; > > Please go ahead and commit. >