From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30663 invoked by alias); 17 Sep 2013 13:59:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30653 invoked by uid 89); 17 Sep 2013 13:59:15 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2013 13:59:15 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VLvo4-0002Yi-6R from Yao_Qi@mentor.com ; Tue, 17 Sep 2013 06:59:08 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 17 Sep 2013 06:59:08 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Tue, 17 Sep 2013 06:59:07 -0700 Message-ID: <52386003.2050501@codesourcery.com> Date: Tue, 17 Sep 2013 13:59:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH 0/4] Match \r\r\n in testsuite References: <87a9ldyu8k.fsf@fleche.redhat.com> <1379423179-8515-1-git-send-email-yao@codesourcery.com> <20130917133530.GH3132@adacore.com> In-Reply-To: <20130917133530.GH3132@adacore.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00511.txt.bz2 On 09/17/2013 09:35 PM, Joel Brobecker wrote: > How about we introduce a new official variable, similar to $hex, > $decimal, etc, which would correctly match new-line output based > on the host? I propose $eol, which is already used, but only in > 2 testcases, so easy to adjust (remove "set eol ..." in those two > testcases). Yeah, that is fine to me. Considering patch 4/4, I'd like introduce two variables, $cr and $eol, which can be defined like this, if [istarget "*-*-mingw*"] { set cr "\r\r" } else { set cr "\r" } set eol "${cr}\n" In this way, patch 3/4 can be updated to something like, - set mi_gdb_prompt "\[(\]gdb\[)\] \r\n" + set mi_gdb_prompt "\[(\]gdb\[)\] ${eol}" and patch 4/4 can be updated to something like, -gdb_test "info trace" "in gdb_recursion_test.*$srcfile:$testline2. +gdb_test "info trace" "in gdb_recursion_test.*$srcfile:$testline2${cr} patch 1/4/ and 2/4 can be unchanged. What do you think? -- Yao (齐尧)