Re: [RFC/TileGX 1/2] fix gdbserver build failure

Jiong Wang
2013-09-17T13:21:39Z

äºŽ 2013/9/17 20:33, Jiong Wang å†™é“:
> äºŽ 2013/9/17 20:30, Joel Brobecker å†™é“:
>>> TileGX gdbserver build failed on native board.
>>>
>>> "srv_tgtobj“ in gdbserver/configure.src not updated.
>>>
>>>
>>> gdbserver/ChangeLog:
>>>
>>> * configure.srv (srv_tgtobj): Remove linux-osdata.o, add
>>> linux-tile-low.o.
>>>
>>> please review.
>> I am trying to understand the circumstances that lead to the failure,
>> and it's been made harder due to the lack of information. After some
>> investigation, my guess is that you're getting some duplicate symbols
>> because linux-osdata.o" is already in srv_tgtobj. Is that correct?
>> If yes, this part of the patch is OK, obvious even (once explained!).
>
> yes, exactly this error.

is this OK to commit ?

>
>
>>
>> I don't understand, however, what difference adding linux-tile-low.o
>> makes in terms of build failure. Again, I have been trying to figure
>> out what lead to the failure, and searched our recent past, but could
>> not find anything. I know the change makes complete sense, but if not
>> logically tied to the build failure you are mentioning, I think we
>> should, if nothing else, document that fact for future archival, and
>> also commit this part of the change separately.
>>
>>> diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv
>>> index 6eb5a8a..f65dd10 100644
>>> --- a/gdb/gdbserver/configure.srv
>>> +++ b/gdb/gdbserver/configure.srv
>>> @@ -340,7 +340,7 @@ case "${target}" in
>>> ;;
>>> tilegx-*-linux*) srv_regobj=reg-tilegx.o
>>> srv_regobj="${srv_regobj} reg-tilegx32.o"
>>> - srv_tgtobj="$srv_linux_obj linux-osdata.o"
>>> + srv_tgtobj="$srv_linux_obj linux-tile-low.o"
>>> srv_linux_regsets=yes
>>> srv_linux_thread_db=yes
>>> ;;
>>
>