Re: [RFC/TileGX 1/2] fix gdbserver build failure

Jiong Wang
2013-09-17T13:36:59Z

äºŽ 2013/9/17 21:30, Joel Brobecker å†™é“:
>>>>> gdbserver/ChangeLog:
>>>>>
>>>>> * configure.srv (srv_tgtobj): Remove linux-osdata.o, add
>>>>> linux-tile-low.o.
>>>>>
>>>>> please review.
>>>> I am trying to understand the circumstances that lead to the failure,
>>>> and it's been made harder due to the lack of information. After some
>>>> investigation, my guess is that you're getting some duplicate symbols
>>>> because linux-osdata.o" is already in srv_tgtobj. Is that correct?
>>>> If yes, this part of the patch is OK, obvious even (once explained!).
>>> yes, exactly this error.
>> is this OK to commit ?
> Only the part that remove linux-osdata.o for now.
>
> I expect that you'll be able to commit the other half, but after
> having explained in detail what this fixes. I suspect that this
> enables some features, rather than fix a failure.

linux-tile-low.o is the target file of TileGX. (it's name is confusing ?)

previous commit by the following wrongly removed the tilegx target file.

commit f7fc28008a4d76dd6e55eb77070eb18e956406a9
Author: Luis Machado <luisgpm@br.ibm.com>
Date: Thu Aug 22 23:46:27 2013 +0000

- srv_tgtobj="linux-low.o linux-tile-low.o linux-osdata.o linux-procfs.o"
- srv_tgtobj="${srv_tgtobj} linux-ptrace.o"
+ srv_tgtobj="$srv_linux_obj linux-osdata.o"

>