[COMMITTED][RFC/TileGX 2/2] fix gdbserver runtime crash

Jiong Wang
2013-09-17T14:06:39Z

On 09/17/2013 09:28 PM, Joel Brobecker wrote:
>>> it's a complicated story and my fault.
>>>
>>> we use Perforce to manage code within the company. This bug is
>>> fixed by Jeff (previous maintainer of TileGX gdb) long time ago in
>>> Perforce, but he
>>> didn't commit it to community. And we mainly test binaries
>>> generated from our Perforce.
>>>
>>> I should be more careful when I check dejagnu test result when
>>> submit to community :)
> No worries, here, just trying to understand the full story.
>
>> is this OK to commit?
> Yes.

committed.

2013-09-16 Jiong Wang <jiwang@tilera.com>

* linux-tile-low.c (tile_regsets): Modify the size field to 64-bit
for each register.

===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-tile-low.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- src/gdb/gdbserver/linux-tile-low.c 2013/06/07 10:46:59 1.4
+++ src/gdb/gdbserver/linux-tile-low.c 2013/09/17 14:00:30 1.5
@@ -124,7 +124,7 @@

static struct regset_info tile_regsets[] =
{
- { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
+ { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8,
GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
{ 0, 0, 0, -1, -1, NULL, NULL }
};

>
>>>>> diff --git a/gdb/gdbserver/linux-tile-low.c
>>>>> b/gdb/gdbserver/linux-tile-low.c
>>>>> index 8963b9a..8efb34e 100644
>>>>> --- a/gdb/gdbserver/linux-tile-low.c
>>>>> +++ b/gdb/gdbserver/linux-tile-low.c
>>>>> @@ -124,7 +124,7 @@ tile_store_gregset (struct regcache
>>>>> *regcache, const void *buf)
>>>>> static struct regset_info tile_regsets[] =
>>>>> {
>>>>> - { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
>>>>> + { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8,
>>>>> GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
>>>>> { 0, 0, 0, -1, -1, NULL, NULL }
>>>>> };