Re: [RFC/TileGX 2/2] fix gdbserver runtime crash

Joel Brobecker
2013-09-17T13:29:00Z

> >it's a complicated story and my fault.
> >
> >we use Perforce to manage code within the company. This bug is
> >fixed by Jeff (previous maintainer of TileGX gdb) long time ago in
> >Perforce, but he
> >didn't commit it to community. And we mainly test binaries
> >generated from our Perforce.
> >
> >I should be more careful when I check dejagnu test result when
> >submit to community :)

No worries, here, just trying to understand the full story.

> is this OK to commit?

Yes.

> >>>diff --git a/gdb/gdbserver/linux-tile-low.c
> >>>b/gdb/gdbserver/linux-tile-low.c
> >>>index 8963b9a..8efb34e 100644
> >>>--- a/gdb/gdbserver/linux-tile-low.c
> >>>+++ b/gdb/gdbserver/linux-tile-low.c
> >>>@@ -124,7 +124,7 @@ tile_store_gregset (struct regcache
> >>>*regcache, const void *buf)
> >>> static struct regset_info tile_regsets[] =
> >>> {
> >>>- { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
> >>>+ { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8,
> >>> GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
> >>> { 0, 0, 0, -1, -1, NULL, NULL }
> >>> };
> >>
> >

--
Joel