From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18670 invoked by alias); 17 Sep 2013 12:33:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18659 invoked by uid 89); 17 Sep 2013 12:33:31 -0000 Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 17 Sep 2013 12:33:31 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.3 required=5.0 tests=BAYES_00,GARBLED_BODY,HELO_MISC_IP,KHOP_THREADED autolearn=no version=3.3.2 X-HELO: USMAMAIL.TILERA.COM Received: from [192.168.0.102] (124.193.190.225) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server (TLS) id 14.0.722.0; Tue, 17 Sep 2013 08:33:27 -0400 Message-ID: <52384C0E.1070808@tilera.com> Date: Tue, 17 Sep 2013 12:33:00 -0000 From: Jiong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [RFC/TileGX 1/2] fix gdbserver build failure References: <50F9148F.3010602@tilera.com> <5237C847.3040908@tilera.com> <20130917123042.GD3132@adacore.com> In-Reply-To: <20130917123042.GD3132@adacore.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-09/txt/msg00495.txt.bz2 于 2013/9/17 20:30, Joel Brobecker 写道: >> TileGX gdbserver build failed on native board. >> >> "srv_tgtobj“ in gdbserver/configure.src not updated. >> >> >> gdbserver/ChangeLog: >> >> * configure.srv (srv_tgtobj): Remove linux-osdata.o, add linux-tile-low.o. >> >> please review. > I am trying to understand the circumstances that lead to the failure, > and it's been made harder due to the lack of information. After some > investigation, my guess is that you're getting some duplicate symbols > because linux-osdata.o" is already in srv_tgtobj. Is that correct? > If yes, this part of the patch is OK, obvious even (once explained!). yes, exactly this error. > > I don't understand, however, what difference adding linux-tile-low.o > makes in terms of build failure. Again, I have been trying to figure > out what lead to the failure, and searched our recent past, but could > not find anything. I know the change makes complete sense, but if not > logically tied to the build failure you are mentioning, I think we > should, if nothing else, document that fact for future archival, and > also commit this part of the change separately. > >> diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv >> index 6eb5a8a..f65dd10 100644 >> --- a/gdb/gdbserver/configure.srv >> +++ b/gdb/gdbserver/configure.srv >> @@ -340,7 +340,7 @@ case "${target}" in >> ;; >> tilegx-*-linux*) srv_regobj=reg-tilegx.o >> srv_regobj="${srv_regobj} reg-tilegx32.o" >> - srv_tgtobj="$srv_linux_obj linux-osdata.o" >> + srv_tgtobj="$srv_linux_obj linux-tile-low.o" >> srv_linux_regsets=yes >> srv_linux_thread_db=yes >> ;; >