From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40176 invoked by alias); 14 Jan 2020 04:20:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40167 invoked by uid 89); 14 Jan 2020 04:20:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2020 04:20:18 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 809F01E05A; Mon, 13 Jan 2020 23:20:16 -0500 (EST) Subject: Re: [PATCH] [AArch64] Convert an int flag variable to bool To: Luis Machado , gdb-patches@sourceware.org Cc: alan.hayward@arm.com References: <20200113174239.7819-1-luis.machado@linaro.org> <20200113174239.7819-2-luis.machado@linaro.org> From: Simon Marchi Message-ID: <52365434-587c-40db-a8f9-ca9d5d39add3@simark.ca> Date: Tue, 14 Jan 2020 04:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200113174239.7819-2-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00363.txt.bz2 On 2020-01-13 12:42 p.m., Luis Machado wrote: > As suggested, the cond variable is really supposed to be a bool. So, > make it so. That looks good to me (and could probably be considered obvious). Thanks, Simon