From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105145-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11784 invoked by alias); 9 Sep 2013 13:46:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11738 invoked by uid 89); 9 Sep 2013 13:46:37 -0000
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2013 13:46:37 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2
X-HELO: relay1.mentorg.com
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1VJ1nV-0004wm-O4 from Yao_Qi@mentor.com ; Mon, 09 Sep 2013 06:46:33 -0700
Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Mon, 9 Sep 2013 06:46:33 -0700
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Mon, 9 Sep 2013 06:46:32 -0700
Message-ID: <522DD104.6090808@codesourcery.com>
Date: Mon, 09 Sep 2013 13:46:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix gdb.base/shreloc.exp: (msymbol) relocated functions have different addresses fail in cygwin
References: <CANFwon0RVVQKLg2Ffm+TWQSKrJRTTtZ-573iJQ_T_HWMrm1hGQ@mail.gmail.com>
In-Reply-To: <CANFwon0RVVQKLg2Ffm+TWQSKrJRTTtZ-573iJQ_T_HWMrm1hGQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg00290.txt.bz2

On 09/09/2013 04:40 PM, Hui Zhu wrote:
> -    send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
> +    if { "${plus_var}" == "" } {
> +	send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
> +    } else {
> +	send_gdb "shell grep -E \" ${plus_var} .* ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
> +    }

Why don't do this unconditionally?

send_gdb "shell grep -E \" T .* ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"

-- 
Yao (齐尧)