From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17014 invoked by alias); 6 Sep 2013 13:34:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17004 invoked by uid 89); 6 Sep 2013 13:34:39 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 13:34:39 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r86DYanb022464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Sep 2013 09:34:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r86DYYXG029844; Fri, 6 Sep 2013 09:34:35 -0400 Message-ID: <5229D9EA.1050306@redhat.com> Date: Fri, 06 Sep 2013 13:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Burgess CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Remove use of deprecated_init_ui_hook from quit_confirm. References: <5229CAA4.4090709@broadcom.com> In-Reply-To: <5229CAA4.4090709@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00231.txt.bz2 On 09/06/2013 01:29 PM, Andrew Burgess wrote: > There are only two places that deprecated_init_ui_hook is set > (to !NULL) that I can find: > > 1. In gdbtk, deprecated_init_ui_hook is used to grab a copy of > argv0, but is then immediately set back to NULL, and Then, was that setting back to NULL a recent change that had that side effect and nobody noticed? Hmm, it's been that way for 10 years: https://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbtk/generic/gdbtk.c?rev=1.36&content-type=text/x-cvsweb-markup&cvsroot=src https://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbtk/generic/gdbtk.c.diff?r1=1.35&r2=1.36&cvsroot=src&f=h Before, it used to be only cleared if not displaying a GUI, like: static void gdbtk_init (char *argv0) { ... /* If there is no DISPLAY environment variable, Tk_Init below will fail, causing gdb to abort. If instead we simply return here, gdb will gracefully degrade to using the command line interface. */ #ifndef _WIN32 if (getenv ("DISPLAY") == NULL) { init_ui_hook = NULL; return; } #endif Guess if nobody complained thus far, people are fine with the alternative text... > 2. In windows-nat.c, deprecated_init_ui_hook is used to solve > an order of initialisation problem when creating a command > alias, in this case deprecated_init_ui_hook is left set. > > In top.c:quit_confirm we check deprecated_init_ui_hook to detect if > there's a GUI running. For (1) above this will not kick in, but > for (2) it does.... however... I don't see why this is a good thing, > as I understand it the windows-nat.c code is not a GUI frontend for > gdb, but is just "running-gdb-on-windows-hosts". I find it hard to > believe that the shorter, less informative, quit message is really > desired... but maybe I've missed something. Right. That very much just looks like an unintentional side effect... > The following patch removes the use of deprecated_init_ui_hook > from quit_confirm, the only change I expect from this is that the > quit message on windows hosts will fall into line with other hosts. > > OK to apply? > Looks fine to me. -- Pedro Alves