From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21359 invoked by alias); 6 Sep 2013 09:07:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21347 invoked by uid 89); 6 Sep 2013 09:07:30 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 09:07:30 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VHs0k-0003QZ-6H from Yao_Qi@mentor.com ; Fri, 06 Sep 2013 02:07:26 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 6 Sep 2013 02:07:26 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Fri, 6 Sep 2013 02:07:25 -0700 Message-ID: <52299B13.3020507@codesourcery.com> Date: Fri, 06 Sep 2013 09:07:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii CC: Subject: Re: [PATCH 2/3] Trust readonly sections if target has memory protection References: <1378432920-7731-1-git-send-email-yao@codesourcery.com> <1378432920-7731-3-git-send-email-yao@codesourcery.com> <83siximqmk.fsf@gnu.org> In-Reply-To: <83siximqmk.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00213.txt.bz2 On 09/06/2013 02:05 PM, Eli Zaretskii wrote: > Is it possible NOT to split documentation changes between changesets, > when they are all parts of the same patch series? Reviewing changes > piecemeal like that is extremely inconvenient and error-prone, > especially since you never tell in the beginning that the > documentation changes are split. TIA. > OK. I re-org the patches and move all doc-related changes into one patch. >> > *** Changes since GDB 7.6 >> > >> >+* The default value of option "trust-readonly-sections" is "auto". GDB >> >+ trusts the contents of read-only sections from the object file on the >> >+ GNU/Linux targets. > The second sentence is in contradiction with the first. "Auto" means > GDB decides automatically whether to trust these section; it does not > mean the decision is YES for GNU/Linux and NO otherwise. > The patch below addresses all your comments on doc. -- Yao (齐尧) gdb: 2013-09-06 Yao Qi * NEWS: Describe the default option of "trust-readonly-sections" becomes "auto" and the related changes. gdb/doc: 2013-09-06 Yao Qi * gdb.texinfo (File): Mention that user has 'set trust-readonly-sections off' to get updated contents if they are modified. Explain the default option of "trust-readonly-sections" is "auto". --- gdb/NEWS | 5 +++++ gdb/doc/gdb.texinfo | 11 +++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index ad97f6f..e60a553 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,11 @@ *** Changes since GDB 7.6 +* The default value of option "trust-readonly-sections" is "auto". GDB + will decide based on the target memory protection features whether to + read readonly sections from object file instead of from the inferior's + memory. + * The "maintenance print objfiles" command now takes an optional regexp. * The "catch syscall" command now works on arm*-linux* targets. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 21250fe..cd7859a 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -16673,12 +16673,19 @@ out of the object file, rather than from the target program. For some targets (notably embedded ones), this can be a significant enhancement to debugging performance. -The default is off. +@item set trust-readonly-sections auto +This is the default mode. @value{GDBN} will decide based on the +target memory protection features whether to read readonly sections +from object file instead of from the inferior's memory, because the +contents of the section in the inferior can't change. @item set trust-readonly-sections off Tell @value{GDBN} not to trust readonly sections. This means that the contents of the section might change while the program is running, -and must therefore be fetched from the target when needed. +and must therefore be fetched from the target when needed. If you +modified the code in the target program, you have to +@code{set trust-readonly-sections off} to guarantee @value{GDBN} reads +updated contents from the target program instead of object file. @item show trust-readonly-sections Show the current setting of trusting readonly sections. -- 1.7.7.6