From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12519 invoked by alias); 6 Sep 2013 08:56:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12509 invoked by uid 89); 6 Sep 2013 08:56:24 -0000 Received: from mms1.broadcom.com (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 08:56:24 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mms1.broadcom.com Received: from [10.9.208.57] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Fri, 06 Sep 2013 01:52:22 -0700 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Fri, 6 Sep 2013 01:54:35 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.1.438.0; Fri, 6 Sep 2013 01:54:35 -0700 Received: from [10.177.73.74] (unknown [10.177.73.74]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 234681A49 for ; Fri, 6 Sep 2013 01:54:34 -0700 (PDT) Message-ID: <5229984A.2060605@broadcom.com> Date: Fri, 06 Sep 2013 08:56:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Give every interpreter a command_loop_proc. References: <5228B883.2010602@broadcom.com> <5228BBB9.4020904@redhat.com> In-Reply-To: <5228BBB9.4020904@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00212.txt.bz2 On 05/09/2013 6:13 PM, Pedro Alves wrote: > On 09/05/2013 05:59 PM, Andrew Burgess wrote: > >> 2013-09-05 Andrew Burgess >> >> * gdb/cli/cli-interp.c (_initialize_cli_interp): Add a >> command_loop_proc to interp_procs. >> * gdb/event-top.c (cli_command_loop): Change signature to match >> interp_command_loop_ftype. >> * gdb/event-top.h (cli_command_loop): Same. >> * gdb/interps.c (interp_new): Require every interpreter to have a >> command_loop_proc. >> (current_interp_command_loop): Just call the command_loop_proc on >> the current interpreter. >> * gdb/tui/tui-interp.c (_initialize_tui_interp): Add a >> command_loop_proc to interp_procs. > > s,gdb/,, in all the above. > > OK. Committed with the above fix. Thanks Pedro & Stan for the review. Andrew