From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9012 invoked by alias); 5 Sep 2013 20:47:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8999 invoked by uid 89); 5 Sep 2013 20:47:36 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2013 20:47:36 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r85KlY6K018176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Sep 2013 16:47:34 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r85KlWeP030980 for ; Thu, 5 Sep 2013 16:47:33 -0400 Message-ID: <5228EDE4.7080101@redhat.com> Date: Thu, 05 Sep 2013 20:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [COMMIT] Re: [PATCH 0/9][gdbserver] Split server.h. References: <1378239999-15533-1-git-send-email-palves@redhat.com> In-Reply-To: <1378239999-15533-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00185.txt.bz2 On 09/03/2013 09:26 PM, Pedro Alves wrote: > The recurring theme of doing: > > #ifdef GDBSERVER > #include "server.h" > #else > #include "defs.h" > #endif > > in common/ code is a bit annoying. I think we'll end up proving a > defs.h in gdbserver, and we'll want to share as much with gdb's as > possible. > > I considered just renaming server.h to defs.h, but looking at > server.h, I think it's better to first split out things that don't > really need to be there. Now that gdbserver's Makefile does automatic > dependency tracking, it's easy enough to split the parts that actually > define interfaces of specific modules to their own files. This series > does that. Some of the new headers remain included in server.h (at > least for now), for they define things that are truly used throughout > the code, and I was hating the fact that I was ending up adding > #include remote-utils.h throughout in a previous attempt, with "utils" > being yet another kitchensink, which I prefer avoiding. Still, I > think it still makes things clearer this way. > > I think we should do the same on the gdb side too. > > Tested on x86_64 Fedora 17. I'll apply it tomorrow, barring comments. I remembered to try cross building gdbserver for mingw, and that showed a couple problems. I fixed them, and pushed the series in. I'll send the final versions of the patches that needed adjustments. -- Pedro Alves