From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Give every interpreter a command_loop_proc.
Date: Thu, 05 Sep 2013 17:14:00 -0000 [thread overview]
Message-ID: <5228BBEE.3030305@earthlink.net> (raw)
In-Reply-To: <5228B883.2010602@broadcom.com>
On 9/5/13 9:59 AM, Andrew Burgess wrote:
> This patch simplifies gdb/interps.c:current_interp_command_loop
> by giving every interpreter a command_loop_proc.
>
> Of the 4 interpreters I'm aware of mi and gdbtk already install
> a command loop proc, while cli and tui don't instead using
> fall-through code in current_interp_command_loop.
>
> I've given cli and tui a command loop proc, and removed the
> fall-through code.
>
> This change does rely on "current_interpreter" never being NULL,
> I believe this is true, and no tests failed here (x86-64 linux),
> but if anyone know different please let me know.
>
> OK to apply?
I like it! This is OK with one caveat:
> * gdb/cli/cli-interp.c (_initialize_cli_interp): Add a
> command_loop_proc to interp_procs.
No redundant "gdb/", please.
Stan
stan@codesourcery.com
prev parent reply other threads:[~2013-09-05 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 17:00 Andrew Burgess
2013-09-05 17:13 ` Pedro Alves
2013-09-06 8:56 ` Andrew Burgess
2013-09-05 17:14 ` Stan Shebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5228BBEE.3030305@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox