From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21387 invoked by alias); 5 Sep 2013 16:04:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21378 invoked by uid 89); 5 Sep 2013 16:04:46 -0000 Received: from mms3.broadcom.com (HELO mms3.broadcom.com) (216.31.210.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2013 16:04:46 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mms3.broadcom.com Received: from [10.9.208.57] by mms3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Thu, 05 Sep 2013 08:54:10 -0700 X-Server-Uuid: B86B6450-0931-4310-942E-F00ED04CA7AF Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Thu, 5 Sep 2013 09:04:33 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Thu, 5 Sep 2013 09:04:33 -0700 Received: from [10.177.73.74] (unknown [10.177.73.74]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id E01B41A4F for ; Thu, 5 Sep 2013 09:04:32 -0700 (PDT) Message-ID: <5228AB8F.30703@broadcom.com> Date: Thu, 05 Sep 2013 16:04:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [PATCH] Remove deprecated_command_loop_hook Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00174.txt.bz2 With these two patches having been committed: https://sourceware.org/ml/gdb-patches/2013-08/msg00872.html https://sourceware.org/ml/insight/2013-q3/msg00029.html deprecated_command_loop_hook is no longer used. This patch removes it. OK to apply? Thanks, Andrew 2013-09-05 Andrew Burgess * gdb/defs.h (deprecated_command_loop_hook): Remove, including references in comments. * gdb/interps.c (current_interp_command_loop): No longer use deprecated_command_loop_hook. (clear_interpreter_hooks): Remove deprecated_command_loop_hook setup. * gdb/top.c (deprecated_command_loop_hook): Remove. diff --git a/gdb/defs.h b/gdb/defs.h index 1e5521f..50b9bfe 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -703,10 +703,8 @@ extern int watchdog; extern char *interpreter_p; /* If a given interpreter matches INTERPRETER_P then it should update - deprecated_command_loop_hook and deprecated_init_ui_hook with the - per-interpreter implementation. */ -/* FIXME: deprecated_command_loop_hook and deprecated_init_ui_hook - should be moved here. */ + deprecated_init_ui_hook with the per-interpreter implementation. */ +/* FIXME: deprecated_init_ui_hook should be moved here. */ struct target_waitstatus; struct cmd_list_element; @@ -716,7 +714,6 @@ extern void (*deprecated_post_add_symbol_hook) (void); extern void (*selected_frame_level_changed_hook) (int); extern int (*deprecated_ui_loop_hook) (int signo); extern void (*deprecated_init_ui_hook) (char *argv0); -extern void (*deprecated_command_loop_hook) (void); extern void (*deprecated_show_load_progress) (const char *section, unsigned long section_sent, unsigned long section_size, diff --git a/gdb/interps.c b/gdb/interps.c index 25500d6..33e0f72 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -320,12 +320,9 @@ void current_interp_command_loop (void) { /* Somewhat messy. For the moment prop up all the old ways of - selecting the command loop. `deprecated_command_loop_hook' - should be deprecated. */ - if (deprecated_command_loop_hook != NULL) - deprecated_command_loop_hook (); - else if (current_interpreter != NULL - && current_interpreter->procs->command_loop_proc != NULL) + selecting the command loop. */ + if (current_interpreter != NULL + && current_interpreter->procs->command_loop_proc != NULL) current_interpreter->procs->command_loop_proc (current_interpreter->data); else cli_command_loop (); @@ -386,7 +383,6 @@ clear_interpreter_hooks (void) deprecated_target_wait_hook = 0; deprecated_call_command_hook = 0; deprecated_error_begin_hook = 0; - deprecated_command_loop_hook = 0; } /* This is a lazy init routine, called the first time the interpreter diff --git a/gdb/top.c b/gdb/top.c index bb71263..b3e7d37 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -199,11 +199,6 @@ void (*deprecated_init_ui_hook) (char *argv0); int (*deprecated_ui_loop_hook) (int); -/* Called instead of command_loop at top level. Can be invoked via - throw_exception(). */ - -void (*deprecated_command_loop_hook) (void); - /* Called from print_frame_info to list the line we stopped in. */