From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4579 invoked by alias); 3 Sep 2013 15:02:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4570 invoked by uid 89); 3 Sep 2013 15:02:16 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2013 15:02:16 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r83F2BrL012696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Sep 2013 11:02:11 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r83F29Wq017793; Tue, 3 Sep 2013 11:02:10 -0400 Message-ID: <5225F9F1.8040403@redhat.com> Date: Tue, 03 Sep 2013 15:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ricard Wanderlof CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH][CRISv32] Add support for threaded debugging References: <5224D319.1000704@redhat.com> <5225F303.4050901@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00082.txt.bz2 On 09/03/2013 03:57 PM, Ricard Wanderlof wrote: > > On Tue, 3 Sep 2013, Pedro Alves wrote: > >>>> This part looks OK, though it did raise some eyebrows to have >>>> GNU/Linux-specific code in cris-tdep.c, rather than in a cris-linux-tdep.c >>>> file. It seems there's no real support for cris bare-metal debugging? >> ... >>> I don't really see the need for it. It doesn't seem like it would be a >>> huge effort (essentially the call to >>> set_gdbarch_fetch_tls_load_module_address and also >>> set_solib_svr4_fetch_link_map_offsets would be put in cris-linux-tdep.c), >>> on the other hand I can't really test that it works as expected, >> ... >> It's mostly about code/design/maintenance sanity. I won't really mind if the >> split isn't done, but note how the fact that there's a Linux port here >> is being missed often in regular maintenance (because people will look >> for *linux-tdep.*) files. cris-tdep.c doesn't call linux_init_abi anywhere >> AFAICT, for example, so the cris port lost the adjustment between v1 >> and v2 of the gdbarch_gdb_signal_{to,from}_target >> patches, just a few weeks back: >> >> http://sourceware.org/ml/gdb-patches/2013-07/msg00002.html >> http://sourceware.org/ml/gdb-patches/2013-07/msg00651.html >> >> Probably other across-the-board changes have been missed. > > That's a good point. I'll see if I find some time to make a rudimentary > split. > > Regarding the specific case above, it's a bit odd though that the CRIS > port was included in the first patch set but not the second, considering > they were supplied by the same person. Still, it still makes your point. It's not odd at all. linux-tdep.c is supposed to be built by all Linux ports, and it was assumed that all Linux ports are calling linux-tdep.c:linux_init_abi. In v2 you see: "- linux-tdep.c now registers the generic converters itself, thus eliminating the need for every target to do so." Since cris is missing linux-tdep.c, it was left out by accident. -- Pedro Alves