From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25557 invoked by alias); 3 Sep 2013 12:03:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25495 invoked by uid 89); 3 Sep 2013 12:03:52 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2013 12:03:52 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r83C3kc6013756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Sep 2013 08:03:46 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r83C3gUP031344; Tue, 3 Sep 2013 08:03:45 -0400 Message-ID: <5225D01E.9040701@redhat.com> Date: Tue, 03 Sep 2013 12:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ricard Wanderlof CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix CRISv32 compilation References: <5224CAE7.9090309@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00068.txt.bz2 On 09/03/2013 08:45 AM, Ricard Wanderlof wrote: > > On Mon, 2 Sep 2013, Pedro Alves wrote: > >> On 08/30/2013 02:12 PM, Ricard Wanderlof wrote: >>> >>> 2013-08-30 Ricard Wanderlof >>> >>> gdbserver >>> >>> * linux-crisv32-low.c: Fix compilation errors. >> >> Write: >> >> * linux-crisv32-low.c (elf_gregset_t): Delete typedef. >> (initialize_low_arch): Call init_registers_crisv32 rather than >> init_register_crisv32. >> >> OK with that change. > > Ok with me. Thanks for the update. Should I resubmit the patch ? If there were no changes since the previous post, we just check it in (and usually reply back saying so). If the patch was approved with changes, we commit, and reply back saying "this is what I checked in", showing the final version. Ultimately, what this means is we always post final version of the patch to the mailing list, exactly as it went in. >> (I can't see how the typedef was breaking the build though) > > With the typedef left in, I get ... > when building gdbserver using the target compiler. Thanks, that's the sort of info that's helpful to have the in the patch rationale (which ideally ends up in the commit log). -- Pedro Alves