From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13801 invoked by alias); 2 Sep 2013 12:50:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13790 invoked by uid 89); 2 Sep 2013 12:50:19 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Sep 2013 12:50:19 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r82Co2ME009180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Sep 2013 08:50:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r82Co0uf015457; Mon, 2 Sep 2013 08:50:01 -0400 Message-ID: <52248978.90500@redhat.com> Date: Mon, 02 Sep 2013 12:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in windows_xfer_memory function References: <5223bb46.c6c0420a.5a41.008dSMTPIN_ADDED_BROKEN@mx.google.com> In-Reply-To: <5223bb46.c6c0420a.5a41.008dSMTPIN_ADDED_BROKEN@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00015.txt.bz2 On 09/01/2013 11:10 PM, Pierre Muller wrote: > This is the patch that Pedro suggested I send > after his commit to remove deprecated_xfer_memory > in windows-nat.c. Thanks. > > Pedro suggested that I submit this patch separately > (which I do here)... and with a gdbserver counterpart, > which I don't... > > I tried, but finally realized that given the > read_memory / write_memory functions type defined > in target.h target_ops structure, > there is no way of passing information of partial > copy and of the length of this partial copy. > Indeed, the comments state that the return value is either 0 for success > or errno... > > This is not compatible with returning information that only part of the > request length > was read/written. Well, we could just change that interface to make it possible... The thing I don't like with doing this only on the native side, is that we're trying to get to a point where we can share the target backends between GDB and gdbserver: . Doing such a change on the GDB side only just means we're pushing the feature-parity goal for the Windows port further away... > 2013-09-01 Pierre Muller > ... > Handle ERROR_PARTIAL_COPY error code. ... This part is OK too. (Please commit it separately from the plongest fix.) -- Pedro Alves