From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31973 invoked by alias); 2 Sep 2013 04:06:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31961 invoked by uid 89); 2 Sep 2013 04:06:03 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Sep 2013 04:06:03 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VGLOn-0002c9-Ki from Muhammad_Waqas@mentor.com ; Sun, 01 Sep 2013 21:05:57 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 1 Sep 2013 21:05:57 -0700 Received: from [137.202.157.111] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Mon, 2 Sep 2013 05:05:55 +0100 Message-ID: <52240E9A.4030708@codesourcery.com> Date: Mon, 02 Sep 2013 04:06:00 -0000 From: Muhammad Waqas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the thread exit References: <521CF7D0.5040801@redhat.com> <1377692710-2885-1-git-send-email-mwaqas@codesourcery.com> <5220C80D.5030502@redhat.com> In-Reply-To: <5220C80D.5030502@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00003.txt.bz2 Thanks. On 08/30/2013 09:27 PM, Pedro Alves wrote: > While reviewing this, I noticed the new test fails for me: > > FAIL: gdb.threads/thread-specific-bp.exp: All stop: continue to breakpoint: set break here > > Investigating, I saw the problem is "info threads" messes up > the current source for breakpoints: > > (gdb) PASS: gdb.threads/thread-specific-bp.exp: All stop: Breakpoint set > break 32 > Breakpoint 4 at 0x323dc08d90: file pthread_join.c, line 32. > ^^^^^^^^^^^^^^^^^^^^^^^ > (gdb) commands > > Does it actually pass for you? I can't see how. It passed for me without your patch. PASS: gdb.threads/thread-specific-bp.exp: All stop: continue to breakpoint: set break here Also I didn't got this problem in any run, I tested it many times. (gdb) PASS: gdb.threads/thread-specific-bp.exp: All stop: Breakpoint set break 32 Breakpoint 4 at 0x4005f7: file ../.././../gdb/gdb/testsuite/./gdb.threads/thread-specific-bp.c, line 32. (gdb) commands