From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2776 invoked by alias); 31 Aug 2013 00:22:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2748 invoked by uid 89); 31 Aug 2013 00:22:48 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 31 Aug 2013 00:22:48 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VFYxg-0001kV-Ho from Yao_Qi@mentor.com ; Fri, 30 Aug 2013 17:22:44 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 30 Aug 2013 17:22:44 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Fri, 30 Aug 2013 17:22:43 -0700 Message-ID: <52213712.1030700@codesourcery.com> Date: Sat, 31 Aug 2013 00:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Vidya Praveen CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/2] Test case for entry values. References: <1376379586-24150-1-git-send-email-yao@codesourcery.com> <1376379586-24150-2-git-send-email-yao@codesourcery.com> <5220B1B6.2000304@arm.com> <20130830152927.GC9666@e103625-lin.cambridge.arm.com> In-Reply-To: <20130830152927.GC9666@e103625-lin.cambridge.arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00946.txt.bz2 On 08/30/2013 11:29 PM, Vidya Praveen wrote: > +if [string equal $bar_call_foo ""] { > + fail "Find the call or branch instruction offset in bar" > + # The following test makes no sense if the offset is unknown. We need > + # to update the pattern above to match call or branch instruction for > + # the target architecture. > + return -1 > +} > > This test fails for ARM targets as they generate 'bl'. As the comment said, the pattern can be updated to match instruction 'bl'. I don't know branch instructions of all architectures, but people familiar with one arch probably can add its branch instruction into the pattern without much effort. -- Yao (齐尧)