Re: [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the thread exit

Pedro Alves
2013-08-27T19:06:44Z

On 08/27/2013 08:02 PM, Pedro Alves wrote:
> On 08/27/2013 12:29 PM, Muhammad Waqas wrote:
>> 2013-08-05 Muhammad Waqas <mwaqas@codesourcery.com>
>>
>> PR gdb/11568
>> * breakpoint.c (remove_threaded_breakpoints): New function.
>> * breakpoint.c (_initialize_breakpoint): function
>> remove_threaded_breakpoints registers with thread_exit.
>
> Indentation isn't right.
> See <https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog>.
>
> "Function" should be uppercase.
>

I meant to suggest something else, but forgot to go back and edit it in.

> * breakpoint.c (_initialize_breakpoint): Function
> remove_threaded_breakpoints registers with thread_exit.

I have a little trouble parsing that. I suggest:

* breakpoint.c (_initialize_breakpoint): Attach
remove_threaded_breakpoints as thread_exit observer.

--
Pedro Alves