From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16334 invoked by alias); 29 Aug 2013 17:47:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16324 invoked by uid 89); 29 Aug 2013 17:47:02 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Aug 2013 17:47:02 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7THl0d5020918 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 13:47:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7THkwUj018951; Thu, 29 Aug 2013 13:46:59 -0400 Message-ID: <521F8912.2020102@redhat.com> Date: Thu, 29 Aug 2013 17:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression References: <20130829111053.GA25662@host2.jankratochvil.net> <521F3B71.1010007@redhat.com> <20130829130359.GA31063@host2.jankratochvil.net> <521F5804.1080604@redhat.com> <87a9k0sgpf.fsf@fleche.redhat.com> <521F5FD1.8020107@redhat.com> <871u5csfrv.fsf@fleche.redhat.com> <87li3kqunt.fsf@fleche.redhat.com> In-Reply-To: <87li3kqunt.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00883.txt.bz2 On 08/29/2013 06:22 PM, Tom Tromey wrote: > Tom> Yeah, I meant the other filestuff.h code, like gdb_socket_cloexec and > Tom> gdb_pipe_cloexec. > > second, the in process agent can't use gdb_socket_cloexec But, why ? > @@ -596,7 +596,7 @@ linux_create_inferior (char *program, char **allargs) > if (remote_connection_is_stdio ()) > { > close (0); > - open ("/dev/null", O_RDONLY); > + gdb_open_cloexec ("/dev/null", O_RDONLY, 0); This is the child opening its stdin. Doesn't look correct to close it on the subsequent exec. > > #include > #include > @@ -147,6 +148,9 @@ trace_vdebug (const char *fmt, ...) > # define ust_loaded gdb_agent_ust_loaded > # define helper_thread_id gdb_agent_helper_thread_id > # define cmd_buf gdb_agent_cmd_buf > + > +/* We don't want to use this one in IPA. */ "because ..." ? > +# define gdb_socket_cloexec socket > #endif -- Pedro Alves