From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20327 invoked by alias); 28 Aug 2013 09:39:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20317 invoked by uid 89); 28 Aug 2013 09:39:04 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Aug 2013 09:39:04 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7S9cxFT012921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Aug 2013 05:38:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7S9ctuG024308; Wed, 28 Aug 2013 05:38:58 -0400 Message-ID: <521DC52F.2050404@redhat.com> Date: Wed, 28 Aug 2013 09:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Joel Brobecker , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] Unbuffer stdout and stderr on windows References: <83eh9uonlg.fsf@gnu.org> <20130815175940.GD6955@ednor.casa.cgf.cx> <520E1109.7000304@redhat.com> <520E1C34.2000907@codesourcery.com> <520E2B13.8020706@redhat.com> <83r4dtn35q.fsf@gnu.org> <520E357E.6080803@redhat.com> <83mwohn0nj.fsf@gnu.org> <520E40CD.7080604@redhat.com> <5215AC28.3030506@codesourcery.com> <20130822141756.GB5221@adacore.com> <5216C6B0.90906@codesourcery.com> <521D0E8A.80303@redhat.com> <521DA52C.9020003@codesourcery.com> In-Reply-To: <521DA52C.9020003@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00813.txt.bz2 On 08/28/2013 08:22 AM, Yao Qi wrote: > +/* Create a ui_file from stderr. */ > + I think this should be in the header.... > +struct ui_file * > +stderr_fileopen (void) > +{ > @@ -129,6 +129,9 @@ extern struct ui_file *mem_fileopen (void); > /* Open/create a STDIO based UI_FILE using the already open FILE. */ > extern struct ui_file *stdio_fileopen (FILE *file); > > +extern struct ui_file *stderr_fileopen (void); > + > + ... as the other functions (seen from context) are documented here too. > /* Open NAME returning an STDIO based UI_FILE. */ > extern struct ui_file *gdb_fopen (const char *name, const char *mode); > + > + /* Method 'to_write_async_safe' is not overwritten, because there's > + no way to flushing a stream in an async-safe manner. Sorry, my own fault -- should read "to flush". This is OK with those fixes. Thanks, -- Pedro Alves