From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27915 invoked by alias); 27 Aug 2013 19:06:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27906 invoked by uid 89); 27 Aug 2013 19:06:44 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2013 19:06:44 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7RJ6fKF022799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Aug 2013 15:06:42 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7RJ6eF3022190; Tue, 27 Aug 2013 15:06:41 -0400 Message-ID: <521CF8C0.6030003@redhat.com> Date: Tue, 27 Aug 2013 19:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Muhammad Waqas CC: gdb-patches@sourceware.org Subject: Re: [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the thread exit References: <521646F5.1010509@redhat.com> <1377602943-9177-1-git-send-email-mwaqas@codesourcery.com> <521CF7D0.5040801@redhat.com> In-Reply-To: <521CF7D0.5040801@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00798.txt.bz2 On 08/27/2013 08:02 PM, Pedro Alves wrote: > On 08/27/2013 12:29 PM, Muhammad Waqas wrote: >> 2013-08-05 Muhammad Waqas >> >> PR gdb/11568 >> * breakpoint.c (remove_threaded_breakpoints): New function. >> * breakpoint.c (_initialize_breakpoint): function >> remove_threaded_breakpoints registers with thread_exit. > > Indentation isn't right. > See . > > "Function" should be uppercase. > I meant to suggest something else, but forgot to go back and edit it in. > * breakpoint.c (_initialize_breakpoint): Function > remove_threaded_breakpoints registers with thread_exit. I have a little trouble parsing that. I suggest: * breakpoint.c (_initialize_breakpoint): Attach remove_threaded_breakpoints as thread_exit observer. -- Pedro Alves