Re: [PATCH 06/13] fix up gdb.mi

Yao Qi
2013-08-25T01:50:06Z

On 08/24/2013 04:36 AM, Tom Tromey wrote:
> # No notification is emitted for 'maint set' commands.
> foreach boolean_opt { "on" "off" } {
> - mi_gdb_test "maint set profile ${boolean_opt}" \
> - "\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \
> - "\"maint set profile ${boolean_opt}\""
> + mi_gdb_test "maint set dwarf2 always-disassemble ${boolean_opt}" \
> + "\\&\"maint set dwarf2 always-disassemble ${boolean_opt}\\\\n\"\r\n\\^done" \
> + "\"maint dwarf2 always-disassemble ${boolean_opt}\""
> }

Tom,
We replace "maint set profile" with "maint set dwarf2
always-disassemble", because the former will cause gdb to generate a
file on exit?

>
> # Full command parameters are included in the notification when a
> diff --git a/gdb/testsuite/gdb.mi/mi-file-transfer.exp b/gdb/testsuite/gdb.mi/mi-file-transfer.exp
> index 9229fde..edf1786 100644
> --- a/gdb/testsuite/gdb.mi/mi-file-transfer.exp
> +++ b/gdb/testsuite/gdb.mi/mi-file-transfer.exp
> @@ -54,15 +54,23 @@ proc mi_gdbserver_run { } {
> }
>
> proc test_file_transfer { filename description } {
> - mi_gdb_test "-target-file-put \"$filename\" \"down-server\"" \
> + if {![is_remote host] && ![is_remote target]} {
> + set up_server [standard_output_file up-server]
> + set down_server [standard_output_file down-server]
> + } else {
> + set up_server up-server
> + set down_server down-server
> + }
> +

IWBN to write comments, IMO.

--
Yao (é½å°§)