Re: [PATCH 06/13] fix up gdb.mi

Tom Tromey
2013-10-17T18:45:49Z

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

>> # No notification is emitted for 'maint set' commands.
>> foreach boolean_opt { "on" "off" } {
>> - mi_gdb_test "maint set profile ${boolean_opt}" \
>> - "\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \
>> - "\"maint set profile ${boolean_opt}\""
>> + mi_gdb_test "maint set dwarf2 always-disassemble ${boolean_opt}" \
>> + "\\&\"maint set dwarf2 always-disassemble
>> ${boolean_opt}\\\\n\"\r\n\\^done" \
>> + "\"maint dwarf2 always-disassemble ${boolean_opt}\""
>> }

Yao> We replace "maint set profile" with "maint set dwarf2
Yao> always-disassemble", because the former will cause gdb to generate a
Yao> file on exit?

Yes. The choice of command is incidental to the test, and this change
avoids the appearance of parallel-unsafe-ness.

>>
>> proc test_file_transfer { filename description } {
>> - mi_gdb_test "-target-file-put \"$filename\" \"down-server\"" \
>> + if {![is_remote host] && ![is_remote target]} {
>> + set up_server [standard_output_file up-server]
>> + set down_server [standard_output_file down-server]
>> + } else {
>> + set up_server up-server
>> + set down_server down-server
>> + }
>> +

Yao> IWBN to write comments, IMO.

Done now, thanks.

Tom