From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18734 invoked by alias); 27 Aug 2013 12:26:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18721 invoked by uid 89); 27 Aug 2013 12:26:32 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2013 12:26:32 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7RCQUXx001672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 27 Aug 2013 08:26:30 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7RCQSdq015004; Tue, 27 Aug 2013 08:26:29 -0400 Message-ID: <521C9AF4.4050704@redhat.com> Date: Tue, 27 Aug 2013 12:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 07/13] fix up gdb.trace References: <1377290210-483-1-git-send-email-tromey@redhat.com> <1377290210-483-8-git-send-email-tromey@redhat.com> In-Reply-To: <1377290210-483-8-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00781.txt.bz2 On 08/23/2013 09:36 PM, Tom Tromey wrote: > diff --git a/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp b/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp ... > +set purely_local 0 > +set tfile_basic tfile-basic.tf Reads a bit odd to have these defaulted, but... > +if {![is_remote host] && ![is_remote target]} { > + set tfile_basic [standard_output_file $tfile_basic] > + set tfile_dir [file dirname $tfile_basic]/ > + set purely_local 1 > +} else { > + set tfile_dir "" ... not this one. I'd move all defaults to this else block. Same in tfile.exp. > +} > -# Make sure we are starting fresh. > -remote_file host delete tfile-basic.tf > -remote_file target delete tfile-basic.tf > +if {!$purely_local} { > + # Make sure we are starting fresh. > + remote_file host delete tfile-basic.tf > + remote_file target delete tfile-basic.tf > +} Shouldn't we delete the previous version of the file in local mode? tfile.exp does keep this unconditional. In tfile.exp: > -gdb_test "target tfile tfile-basic.tf" "Created tracepoint.*" \ > +gdb_test "target tfile $tfile_basic" "Created tracepoint.*" \ > "target tfile" > > gdb_test "info trace" ".*tracepoint.*in write_basic_trace_file.*" \ > @@ -108,7 +125,7 @@ gdb_start > > gdb_load $binfile > > -gdb_test "target tfile tfile-error.tf" "Created tracepoint.*" \ > +gdb_test "target tfile $tfile_error" "Created tracepoint.*" \ > "target tfile" This seems to introduce duplicated messages in gdb.sum. (A good exercise would be to compare gdb.sum before/after whole series.) -- Pedro Alves