From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27768 invoked by alias); 27 Aug 2013 11:43:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27739 invoked by uid 89); 27 Aug 2013 11:43:18 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2013 11:43:18 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7RBhFpU023514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Aug 2013 07:43:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7RBhDwM026492; Tue, 27 Aug 2013 07:43:14 -0400 Message-ID: <521C90D1.60909@redhat.com> Date: Tue, 27 Aug 2013 11:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Use mi_getopt_silent References: <51FA557F.5@redhat.com> <1377402123-3740-1-git-send-email-yao@codesourcery.com> <1377402123-3740-2-git-send-email-yao@codesourcery.com> <521B80B5.1020108@redhat.com> <521C1CF9.3060907@codesourcery.com> In-Reply-To: <521C1CF9.3060907@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00779.txt.bz2 On 08/27/2013 04:28 AM, Yao Qi wrote: > On 08/27/2013 12:22 AM, Pedro Alves wrote: >>>> -int >>>> -mi_getopt (const char *prefix, >>>> - int argc, char **argv, >>>> - const struct mi_opt *opts, >>>> - int *oind, char **oarg) >>>> +/* See comments about mi_getopt and mi_getopt_silent in mi-getopt.h. >>>> + When there is an unknown option, if ERROR_ON_UNKNOWN is true, it >>>> + throws an error, otherwise return -1. */ >> ("throws" -> "returns"). I'd suggest: >> > > I assume you meant "return" -> "returns" here. Yeah, specifically, I meant, you have "it throws", so it should be "it returns", as the subject is still "it". > I also rename mi_getopt_silent to mi_getopt_allow_unknown. Excellent! I like that. -- Pedro Alves