Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Muhammad Bilal <mbilal@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [patch] fix for checking the command ambiguousness.
Date: Tue, 27 Aug 2013 09:22:00 -0000	[thread overview]
Message-ID: <521C6FDD.3090909@codesourcery.com> (raw)

Hi,

While I was looking the code of 'lookup_cmd_composition' function, I saw
there incorrect command ambiguousness checking.
Actually  'find_cmd' function does not return the CMD_LIST_AMBIGUOUS
macro, whereas  'lookup_cmd_1' function return this macro on the bases 
of 'nfound'
variable and 'nfound' variable determines the command ambiguousness.

So, checking the command  ambiguousness condition with 'nfound' variables
fixes the bug.


  gdb/cli/cli-decode.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


2013-07-27  Muhammad Bilal  <mbilal@codesourcery.com>

     * cli/cli-decode.c (lookup_cmd_composition): Check command 
ambiguousness
     with 'nfound' instead of CMD_LIST_AMBIGOUS.

diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c
index 2fdd9e4..30000d8 100644
--- a/gdb/cli/cli-decode.c
+++ b/gdb/cli/cli-decode.c
@@ -1729,7 +1729,7 @@ lookup_cmd_composition (const char *text,
           *cmd = find_cmd (command, len, cur_list, 1, &nfound);
         }

-      if (*cmd == CMD_LIST_AMBIGUOUS)
+      if (nfound > 1)
         {
           return 0;              /* ambiguous */
         }


OK?




Thanks,
-Bilal


             reply	other threads:[~2013-08-27  9:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  9:22 Muhammad Bilal [this message]
2013-08-27 18:10 ` Pedro Alves
2013-08-28  8:16   ` Muhammad Bilal
     [not found]     ` <521DE287.2010208@redhat.com>
2013-08-28 14:17       ` Muhammad Bilal
2013-09-04 12:34         ` Muhammad Bilal
2013-09-10 10:33           ` Muhammad Bilal
2013-09-17 16:28             ` Muhammad Bilal
2013-09-17 16:31               ` Pedro Alves
2013-11-07 15:04                 ` Tom Tromey
2013-11-07 14:53         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521C6FDD.3090909@codesourcery.com \
    --to=mbilal@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox