From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29800 invoked by alias); 26 Aug 2013 16:52:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29791 invoked by uid 89); 26 Aug 2013 16:52:47 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 16:52:47 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=ALL_TRUSTED,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7QGqgr7014872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Aug 2013 12:52:42 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7QGqePP016523; Mon, 26 Aug 2013 12:52:41 -0400 Message-ID: <521B87D8.1040303@redhat.com> Date: Mon, 26 Aug 2013 16:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [PATCH] windows-nat.c: Don't install a deprecated_xfer_memory method. References: <20130823181245.4023.25651.stgit@brno.lan> <001201cea048$e2f17ed0$a8d47c70$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001201cea048$e2f17ed0$a8d47c70$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00760.txt.bz2 On 08/23/2013 10:36 PM, Pierre Muller wrote: > Hi Pedro, > > I think that your patch can be further enhanced by this change: > ReadProcessMemory and WriteProcessMemory > function both fail and report ERROR_PARTIAL_COPY > in GetLastError > if only a part of the requested memory was read/written. Interesting. It does sound like a good idea. However, could you send that as a separate patch, please? Otherwise, the single combined patch can potentially cause issues due to two logically unrelated changes: potential problems caused by not installing deprecated_xfer_memory anymore, and instead going through xfer_partial directly; and then potential problems due to that change. Keeping the patches separate allows for better bisecting for what might have caused a regression. > > Adding partial memory read/writes to windows native > allows for instance to get the true location at which a > memory chuck is not available anymore instead of the > start position of the read/write attempt if > it crosses over to region not readable or not writable. Thanks, -- Pedro Alves