From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14473 invoked by alias); 26 Aug 2013 16:40:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14442 invoked by uid 89); 26 Aug 2013 16:40:19 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 16:40:18 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7QGeGhS004051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Aug 2013 12:40:16 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7QGeE28031529; Mon, 26 Aug 2013 12:40:15 -0400 Message-ID: <521B84EE.70805@redhat.com> Date: Mon, 26 Aug 2013 16:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add options to skip unavailable locals References: <51FA557F.5@redhat.com> <1377402123-3740-1-git-send-email-yao@codesourcery.com> <1377402123-3740-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1377402123-3740-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00759.txt.bz2 Looks good to me. A few tiny-tiny suggestions below: > * NEWS: Mention the new option "--skip-unavailable" to MI > commands '-stack-list-locals' '-stack-list-arguments' and ^ Missing comma. > '-stack-list-variables'. > Errors are printed as if they would be the parameter value. Use > - zeroed ARG iff it should not be printed according to VALUES. */ > + zeroed ARG iff it should not be printed according to VALUES. If > + SKIP_UNAVAILABLE is true, print ARG if it is available. */ "is true, only print ARG" > > static void > list_arg_or_local (const struct frame_arg *arg, enum what_to_list what, > - enum print_values values) > + enum print_values values, int skip_unavailable) > { > /* Print a list of the objects for the frame FI in a certain form, > which is determined by VALUES. The objects can be locals, > - arguments or both, which is determined by WHAT. */ > + arguments or both, which is determined by WHAT. If SKIP_UNAVAILABLE > + is true, print the arguments or local variables whose values are > + available. */ "is true, only print the" > > static void > list_args_or_locals (enum what_to_list what, enum print_values values, > - struct frame_info *fi) > + struct frame_info *fi, int skip_unavailable) > { > struct block *block; -- Pedro Alves