From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13899 invoked by alias); 26 Aug 2013 15:42:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13890 invoked by uid 89); 26 Aug 2013 15:42:04 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 15:42:04 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7QFfxV8001392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Aug 2013 11:41:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7QF0Dt1025935; Mon, 26 Aug 2013 11:00:14 -0400 Message-ID: <521B6D7D.6080406@redhat.com> Date: Mon, 26 Aug 2013 15:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Bunk, Bernd" CC: Eli Zaretskii , "tromey@redhat.com" , "gdb-patches@sourceware.org" Subject: Re: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds. References: <1377161766-8318-1-git-send-email-bernd.bunk@intel.com> <8361uxkbi9.fsf@gnu.org> <52166564.90605@redhat.com> <521773E9.1060704@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00746.txt.bz2 On 08/26/2013 01:01 PM, Bunk, Bernd wrote: >> From: Pedro Alves [mailto:palves@redhat.com] >>>> See gdb/configure.ac, gdb/Makefile.in and gdbtk/gdb.rc etc. >>>> Isn't this going to conflict on gdbtk builds? >>> See above, yes it would. >> >> Well, it just looks to me that the gdbres.rc resource and the icon are >> presently only used on Cygwin-hosts builds, because nobody bothered to >> tweak that configure bit to make it work on mingw-hosts too. That bit >> is there since at least 2000, and I believe MinGW host support came in >> much after. Cygwin wanting pretty icons, but MinGW not is kind of >> strange, wouldn't you say? :-) >> >> Do you have any hint at what one would need to do, if one were to >> enable that icon resource on mingw too? > I can offer to merge this icon into my mingw rc file in a later checkin. Thanks. Note the icon should probably only be used for gdbtk/insight builds, not plain command line gdb builds, and should probably stay in the gdbtk/ dir. If it's possible to link in more than one rc file, than there'd be no problem. But if that's not possible, then we'd need something more magical... But tbh I cannot even find the sources (icon or gdbtk folder). Someone checked in build rules for something that is not on the same branch (upstream/master). I am new to this gdb coding, but I would never do something like this... The gdbtk/ directory is part of insight, which (currently) lives in the same repository but in a different cvs module. You'll need to "cvs ... co insight" instead of "cvs ... co gdb" to get it. -- Pedro Alves